r103369 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103368‎ | r103369 | r103370 >
Date:20:01, 16 November 2011
Author:tparscal
Status:ok
Tags:
Comment:
Fixed issue in processing removal transactions - globalRange is now defined always, so we need to check for range instead
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/es.TransactionProcessor.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/es.TransactionProcessor.js
@@ -219,7 +219,7 @@
220220 var oldNodes = [], newData = [], firstKeptNode = true, lastElement;
221221 for ( var i = 0; i < ranges.length; i++ ) {
222222 oldNodes.push( ranges[i].node );
223 - if ( ranges[i].globalRange !== undefined ) {
 223+ if ( ranges[i].range !== undefined ) {
224224 // We have to keep part of this node
225225 if ( firstKeptNode ) {
226226 // This is the first node we're keeping

Status & tagging log