r103310 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103309‎ | r103310 | r103311 >
Date:10:42, 16 November 2011
Author:hashar
Status:ok
Tags:
Comment:
fix ucompare not showing images

ucompare|jquery|browser does not update parent div when setting a children
background-image. This local patch to upstream jquery.ucompare plugin makes
sure the element is properly sized.

Follow up r103309, see commit message there too.
Modified paths:
  • /trunk/extensions/VipsScaler/modules/jquery.ucompare/js/jquery.ucompare.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VipsScaler/modules/jquery.ucompare/js/jquery.ucompare.js
——@@ -31,6 +31,14 @@
3232 overflow: "hidden",
3333 position: "relative"
3434 });
 35+
 36+ /**
 37+ * MediaWiki hack:
 38+ * Parent element height can still be 0px after hiding the images
 39+ * so we really want to update its dimensions.
 40+ */
 41+ d.width(h); d.height(i);
 42+
3543 d.append('<div class="uc-mask"></div>');
3644 d.append('<div class="uc-bg"></div>');
3745 d.append('<div class="uc-caption">' + g + "</div>");

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103309Better image comparaison using jquery.ucompare...hashar10:38, 16 November 2011

Status & tagging log