r103195 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103194‎ | r103195 | r103196 >
Date:17:25, 15 November 2011
Author:rsterbin
Status:deferred
Tags:
Comment:
Added bucket 1 with temporary markup:
- Renamed bucket 5 specific messages to prefix with "bucket5"
- Added messages for bucket 1, plus some shared messages
- Updated jquery plugin:
- Added $.articleFeedbackv5.buckets[1]
- Broke out wrapper html with error panel from bucket 5 and put it into
$.articleFeedbackv5.buildForm
- Moved functions out of bucket 5 and into the main object:
markShowstopperError(), lockForm(), and unlockForm()
- Updated ArticleFeedbackv5.hooks.php to change message names

Added the ability to request a bucket in the url (e.g. ?bucket=1):
- Updated $.articleFeedbackv5.loadForm() to send it to the api
- Updated ApiQueryArticleFeedbackv5:
- Updated getBucket() to take the params as an argument, check for
"bucketreqested", check it against a list of allowed buckets, and use
it if it matches; if not, select a random bucket from the allowed list
for now (later, this will use whatever algorithm ends up being
selected)
- Updated getAllowedParams() and getParamDescription() to add
"bucketreqested"
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/api/ApiQueryArticleFeedbackv5.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

The diff is too large to display.

Status & tagging log