r103139 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103138‎ | r103139 | r103140 >
Date:10:10, 15 November 2011
Author:petrb
Status:deferred
Tags:
Comment:
fixed sql, it was selecting wrong field, and compared it wrong
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php (modified) (history)
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.status.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.status.php
@@ -27,11 +27,10 @@
2828 $t_time = OnlineStatusBar::getTimeoutDate();
2929 $dbr = wfGetDB( DB_SLAVE );
3030 $w_time = OnlineStatusBar::getTimeoutDate( true );
31 - $result = $dbr->selectField( 'online_status', 'username', array( 'username' => $user->getName(),
 31+ $result = $dbr->selectField( 'online_status', 'timestamp', array( 'username' => $user->getName(),
3232 "timestamp > " . $dbr->addQuotes( $dbr->timestamp( $t_time ) ) ),
3333 __METHOD__, array( 'LIMIT 1', 'ORDER BY timestamp DESC' ) );
3434
35 -
3635 if ( $result === false ) {
3736 $status = $wgOnlineStatusBarDefaultOffline;
3837 } else {
@@ -39,7 +38,7 @@
4039 if ( $user->isLoggedIn() ) {
4140 $status = $user->getOption( 'OnlineStatusBar_status', $wgOnlineStatusBarDefaultOnline );
4241 if ( $delayed_check ) {
43 - if ( $result[0]->timestamp > w_time ) {
 42+ if ( $result < $w_time ) {
4443 $status = 'write';
4544 }
4645 }
Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php
@@ -131,7 +131,7 @@
132132 global $wgOnlineStatusBar_WriteTime, $wgOnlineStatusBar_LogoutTime;
133133
134134 if ($delayed) {
135 - return wfTimestamp( TS_UNIX ) - $wgOnlineStatusBar_WriteTime;
 135+ return wfTimestamp( TS_UNIX ) + $wgOnlineStatusBar_WriteTime;
136136 }
137137
138138 return wfTimestamp( TS_UNIX ) - $wgOnlineStatusBar_LogoutTime;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103135Performance updatepetrb09:35, 15 November 2011

Status & tagging log