r103116 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103115‎ | r103116 | r103117 >
Date:01:34, 15 November 2011
Author:aaron
Status:ok
Tags:
Comment:
FU r102825:
* Updated FlaggedRevs::styleUrlPath too (grepped, no other usages)
* Also moved styleUrlPath() to FlaggedRevsXML
Modified paths:
  • /trunk/extensions/FlaggedRevs/backend/FlaggedRevs.class.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/frontend/FlaggedRevsXML.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/frontend/FlaggedRevsXML.php
@@ -5,6 +5,15 @@
66 */
77 class FlaggedRevsXML {
88 /**
 9+ * Get the URL path to where the client side resources are (JS, CSS, images..)
 10+ * @return string
 11+ */
 12+ public static function styleUrlPath() {
 13+ global $wgExtensionAssetsPath;
 14+ return "$wgExtensionAssetsPath/FlaggedRevs/frontend/modules";
 15+ }
 16+
 17+ /**
918 * Get a selector of reviewable namespaces
1019 * @param int $selected, namespace selected
1120 * @param $all Mixed: Value of an item denoting all namespaces, or null to omit
@@ -293,7 +302,7 @@
294303 * @return string
295304 */
296305 public static function ratingArrow() {
297 - $encPath = htmlspecialchars( FlaggedRevs::styleUrlPath() . '/img' );
 306+ $encPath = htmlspecialchars( self::styleUrlPath() . '/img' );
298307 $img = '<img id="mw-fr-revisiontoggle" class="fr-toggle-arrow"';
299308 $img .= " src=\"{$encPath}/arrow-down.png\" style=\"display:none;\"";
300309 $img .= ' alt="' . wfMsgHtml( 'revreview-toggle-title' ) . '" />';
@@ -351,7 +360,7 @@
352361 * @return string
353362 */
354363 public static function draftStatusIcon() {
355 - $encPath = htmlspecialchars( FlaggedRevs::styleUrlPath() . '/img' );
 364+ $encPath = htmlspecialchars( self::styleUrlPath() . '/img' );
356365 $encTitle = wfMsgHtml( 'revreview-draft-title' );
357366 return "<img class=\"flaggedrevs-icon\" src=\"$encPath/1.png\"" .
358367 " alt=\"$encTitle\" title=\"$encTitle\" />";
@@ -363,7 +372,7 @@
364373 * @return string
365374 */
366375 public static function stableStatusIcon( $isQuality ) {
367 - $encPath = htmlspecialchars( FlaggedRevs::styleUrlPath() . '/img' );
 376+ $encPath = htmlspecialchars( self::styleUrlPath() . '/img' );
368377 $file = $isQuality ? '3.png' : '2.png';
369378 $encTitle = $isQuality
370379 ? wfMsgHtml( 'revreview-quality-title' )
@@ -378,7 +387,7 @@
379388 * @return string
380389 */
381390 public static function lockStatusIcon( $flaggedArticle ) {
382 - $encPath = htmlspecialchars( FlaggedRevs::styleUrlPath() . '/img' );
 391+ $encPath = htmlspecialchars( self::styleUrlPath() . '/img' );
383392 if ( $flaggedArticle->isPageLocked() ) {
384393 $encTitle = wfMsgHtml( 'revreview-locked-title' );
385394 return "<img class=\"flaggedrevs-icon\" src=\"$encPath/doc-magnify.png\"" .
Index: trunk/extensions/FlaggedRevs/backend/FlaggedRevs.class.php
@@ -383,15 +383,6 @@
384384 }
385385
386386 /**
387 - * Get the URL path to where the client side resources are (JS, CSS, images..)
388 - * @return string
389 - */
390 - public static function styleUrlPath() {
391 - global $wgExtensionAssetsPath;
392 - return "$wgExtensionAssetsPath/FlaggedRevs/presentation/modules";
393 - }
394 -
395 - /**
396387 * Get the 'diffonly=' value for diff URLs. Either ('1','0','')
397388 * @return array
398389 */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102825* Renamed presentation/ to frontend/...aaron23:57, 11 November 2011

Status & tagging log