r103093 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103092‎ | r103093 | r103094 >
Date:00:27, 15 November 2011
Author:robin
Status:ok
Tags:
Comment:
Minor RTL improvements for MoodBar: add background-position so the icon doesn't overlap the "Feedback about editing" link; make "moodbar-what-collapsed" optional so RTL languages can change it to an arrow in the other direction
Modified paths:
  • /trunk/extensions/MoodBar/MoodBar.i18n.php (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.init.css (modified) (history)
  • /trunk/translatewiki/MediaWiki/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/translatewiki/MediaWiki/mediawiki-defines.txt
@@ -879,8 +879,9 @@
880880 Mood Bar
881881 aliasfile = MoodBar/MoodBar.alias.php
882882 ignored = tooltip-p-moodbar-trigger-editing, tooltip-p-moodbar-trigger-feedback, tooltip-p-moodbar-trigger-share, moodbar-what-target
883 -ignored = moodbar-what-expanded, moodbar-what-collapsed, moodbar-loading-subtitle
 883+ignored = moodbar-what-expanded, moodbar-loading-subtitle
884884 ignored = moodbar-hide-intro, moodbar-restore-intro
 885+optional = moodbar-what-collapsed
885886
886887 Most Revisors
887888 aliasfile = MostRevisors/MostRevisors.alias.php
Index: trunk/extensions/MoodBar/MoodBar.i18n.php
@@ -32,7 +32,7 @@
3333 'tooltip-moodbar-what' => 'Learn more about this feature',
3434 'moodbar-what-target' => 'http://www.mediawiki.org/wiki/MoodBar',
3535 'moodbar-what-label' => 'What is this?',
36 - 'moodbar-what-collapsed' => '▶', // Ignore, do not translate. ▼
 36+ 'moodbar-what-collapsed' => '▶', // Optional, only change e.g. for RTL languages. ▼
3737 'moodbar-what-expanded' => '▼', // Ignore, do not translate. ▶
3838 'moodbar-what-content' => 'This feature is designed to help the community understand the experience of people editing the site.
3939 For more information, please visit the $1.',
Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.init.css
@@ -15,5 +15,6 @@
1616 /* @embed */
1717 background: url(images/icon-speechbubble-blue.png);
1818 background-repeat: no-repeat;
 19+ background-position: left;
1920 padding-left: 18px;
2021 }

Status & tagging log