r103060 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103059‎ | r103060 | r103061 >
Date:22:51, 14 November 2011
Author:bsitu
Status:ok
Tags:
Comment:
Bug 32108 - Adding server side check for empty comment
Modified paths:
  • /trunk/extensions/MoodBar/FeedbackItem.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/FeedbackItem.php
@@ -193,7 +193,8 @@
194194 } elseif ( $key == 'type' ) {
195195 return in_array( $value, self::$validTypes );
196196 } elseif ( $key == 'comment' ) {
197 - return mb_strlen( $value ) <= 140;
 197+ $comment_len = mb_strlen( $value );
 198+ return $comment_len > 0 && $comment_len <= 140;
198199 }
199200
200201 return true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r103061this fixes bug32108 - Adding server side check for empty commentbsitu22:57, 14 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103057Moodbar phase 1 bug fixes, fixes bug32108 and addresses others in FeedbackDas...rmoen22:40, 14 November 2011

Status & tagging log