r103034 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103033‎ | r103034 | r103035 >
Date:21:21, 14 November 2011
Author:hartman
Status:ok
Tags:
Comment:
Make sure a row is closed in the toolbar.

Patch by User:Lupo
Bug 31673
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js
@@ -534,7 +534,7 @@
535535 for ( var i = 0; i< headings.length; i++ ) {
536536 html += '<th>' + $.wikiEditor.autoMsg( headings[i], ['html', 'text'] ) + '</th>';
537537 }
538 - return html;
 538+ return html + '</tr>';
539539 },
540540 buildRow : function( context, row ) {
541541 var html = '<tr>';
@@ -542,8 +542,7 @@
543543 html += '<td class="cell cell-' + cell + '" valign="top"><span>' +
544544 $.wikiEditor.autoMsg( row[cell], ['html', 'text'] ) + '</span></td>';
545545 }
546 - html += '</tr>';
547 - return html;
 546+ return html + '</tr>';
548547 },
549548 buildCharacter : function( character, actions ) {
550549 if ( typeof character == 'string' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r103046Harden the toolbar builder for character insertion a bit against incorrect co...hartman21:55, 14 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102980Remove stray comma per bug 31673 comment 4catrope13:51, 14 November 2011

Status & tagging log