r102968 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102967‎ | r102968 | r102969 >
Date:11:08, 14 November 2011
Author:nikerabbit
Status:deferred
Tags:
Comment:
Stylize
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_ConceptPage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_OrderedListPage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_PropertyPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_ConceptPage.php
@@ -27,7 +27,7 @@
2828
2929 /**
3030 * Returns the HTML which is added to $wgOut after the article text.
31 - *
 31+ *
3232 * @return string
3333 */
3434 protected function getHtml() {
@@ -40,7 +40,7 @@
4141 $queryResult = $store->getQueryResult( $query );
4242
4343 $diWikiPages = $queryResult->getResults();
44 - if ($this->until !== '' ) {
 44+ if ( $this->until !== '' ) {
4545 $diWikiPages = array_reverse( $diWikiPages );
4646 }
4747
@@ -76,7 +76,7 @@
7777 */
7878 // private function formatList( $cutoff = 6 ) {
7979 // $end = count( $this->diWikiPages );
80 -//
 80+//
8181 // if ( $end > $this->limit ) {
8282 // if ( $this->until !== '' ) {
8383 // $start = 1;
@@ -87,7 +87,7 @@
8888 // } else {
8989 // $start = 0;
9090 // }
91 -//
 91+//
9292 // if ( count ( $this->diWikiPages ) > $cutoff ) {
9393 // return $this->columnList( $start, $end, $this->diWikiPages );
9494 // } elseif ( count( $this->diWikiPages ) > 0 ) {
Index: trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_OrderedListPage.php
@@ -5,39 +5,39 @@
66 * article pages for Concept and Property pages. This is mainly parameter
77 * handling and some very basic output control.
88 *
9 - * @file SMW_OrderedListPage.php
 9+ * @file SMW_OrderedListPage.php
1010 * @ingroup SMW
11 - *
 11+ *
1212 * @author Nikolas Iwan
1313 * @author Markus Krötzsch
14 - * @author Jeroen De Dauw
 14+ * @author Jeroen De Dauw
1515 */
1616 abstract class SMWOrderedListPage extends Article {
1717
1818 /**
1919 * Limit for results per page.
20 - *
 20+ *
2121 * @var integer
2222 */
2323 protected $limit;
2424
2525 /**
2626 * Start string: print $limit results from here.
27 - *
 27+ *
2828 * @var string
2929 */
3030 protected $from;
31 -
 31+
3232 /**
3333 * End string: print $limit results strictly before this article.
34 - *
 34+ *
3535 * @var string
36 - */
 36+ */
3737 protected $until;
38 -
 38+
3939 /**
4040 * Cache for the current skin, obtained from $wgUser.
41 - *
 41+ *
4242 * @var Skin
4343 */
4444 protected $skin;
@@ -92,7 +92,7 @@
9393 * (e.g. $limit). Method can be overwritten in this case.
9494 * If the method returns false, nothing will be printed besides
9595 * the original article.
96 - *
 96+ *
9797 * @return true
9898 */
9999 protected function initParameters() {
@@ -102,16 +102,16 @@
103103
104104 /**
105105 * Returns the HTML which is added to $wgOut after the article text.
106 - *
 106+ *
107107 * @return string
108108 */
109109 protected abstract function getHtml();
110110
111111 /**
112112 * Like Article's getTitle(), but returning a suitable SMWDIWikiPage.
113 - *
 113+ *
114114 * @since 1.6
115 - *
 115+ *
116116 * @return SMWDIWikiPage
117117 */
118118 protected function getDataItem() {
Index: trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_PropertyPage.php
@@ -7,7 +7,7 @@
88 *
99 * @file SMW_PropertyPage.php
1010 * @ingroup SMW
11 - *
 11+ *
1212 * @author Markus Krötzsch
1313 */
1414 class SMWPropertyPage extends SMWOrderedListPage {
@@ -25,7 +25,7 @@
2626
2727 /**
2828 * Returns the HTML which is added to $wgOut after the article text.
29 - *
 29+ *
3030 * @return string
3131 */
3232 protected function getHtml() {
@@ -62,7 +62,7 @@
6363 }
6464
6565 $result .= wfMsgExt( 'smw_subpropertyarticlecount', array( 'parsemag' ), $resultCount ) . "</p>\n";
66 -
 66+
6767 if ( $resultCount < 6 ) {
6868 $result .= SMWPageLister::getShortList( 0, $resultCount, $subproperties, null );
6969 } else {
@@ -159,13 +159,13 @@
160160 $searchlink = SMWInfolink::newBrowsingLink( '+', $dvWikiPage->getShortHTMLText() );
161161 $r .= '<tr><td class="smwpropname">' . $dvWikiPage->getShortHTMLText( smwfGetLinker() ) .
162162 '&#160;' . $searchlink->getHTML( smwfGetLinker() ) . '</td><td class="smwprops">';
163 -
 163+
164164 // Property values
165165 $ropts = new SMWRequestOptions();
166166 $ropts->limit = $smwgMaxPropertyValues + 1;
167167 $values = $store->getPropertyValues( $diWikiPage, $this->mProperty, $ropts );
168168 $i = 0;
169 -
 169+
170170 foreach ( $values as $di ) {
171171 if ( $i != 0 ) {
172172 $r .= ', ';