r102966 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102965‎ | r102966 | r102967 >
Date:10:35, 14 November 2011
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: MFT r102962, r102964
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/CentralNotice/special/SpecialBannerController.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/Vector/modules/ext.vector.collapsibleTabs.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/Vector/modules/ext.vector.collapsibleTabs.js
@@ -1,7 +1,7 @@
22 /*
33 * Collapsible tabs for Vector
44 */
5 -$(document).ready( function() {
 5+jQuery(function( $ ) {
66 var rtl = $( 'body' ).is( '.rtl' );
77
88 // Overloading the moveToCollapsed function to animate the transition
Property changes on: branches/wmf/1.18wmf1/extensions/Vector/modules/ext.vector.collapsibleTabs.js
___________________________________________________________________
Modified: svn:mergeinfo
99 Merged /trunk/extensions/Vector/modules/ext.vector.collapsibleTabs.js:r102962,102964
Index: branches/wmf/1.18wmf1/extensions/CentralNotice/special/SpecialBannerController.php
@@ -70,7 +70,7 @@
7171 "' + bannerPage + '\"></script>';\n";
7272 $js .= <<<JAVASCRIPT
7373 if ( document.cookie.indexOf( 'centralnotice_'+bannerType+'=hide' ) == -1 ) {
74 - $( '#siteNotice' ).prepend( '<div id="centralNotice" class="' +
 74+ jQuery( '#siteNotice' ).prepend( '<div id="centralNotice" class="' +
7575 ( wgNoticeToggleState ? 'expanded' : 'collapsed' ) +
7676 ' cn-' + bannerType + '">'+bannerScript+'</div>' );
7777 }
@@ -137,7 +137,7 @@
138138 }
139139 }
140140 }
141 - $( document ).ready( function () {
 141+ jQuery( document ).ready( function ( $ ) {
142142 // Initialize the query string vars
143143 $.centralNotice.fn.getQueryStringVariables();
144144 if( $.centralNotice.data.getVars['banner'] ) {
@@ -184,7 +184,7 @@
185185 }
186186 }
187187 function hideBanner() {
188 - $( '#centralNotice' ).hide(); // Hide current banner
 188+ jQuery( '#centralNotice' ).hide(); // Hide current banner
189189 var bannerType = $.centralNotice.data.bannerType;
190190 if ( bannerType === undefined ) bannerType = 'default';
191191 setBannerHidingCookie( bannerType ); // Hide future banners of the same type
Property changes on: branches/wmf/1.18wmf1/extensions/CentralNotice/special/SpecialBannerController.php
___________________________________________________________________
Modified: svn:mergeinfo
192192 Merged /trunk/extensions/CentralNotice/special/SpecialBannerController.php:r102962,102964

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102962Properly alias $ to jQuery in collapsibleTabscatrope10:30, 14 November 2011
r102964Fix $ aliasing in CentralNoticecatrope10:33, 14 November 2011

Status & tagging log