r102887 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102886‎ | r102887 | r102888 >
Date:11:28, 13 November 2011
Author:aaron
Status:ok
Tags:
Comment:
Added rollback-related comment to nextSequenceValue()
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -2258,6 +2258,10 @@
22592259 * Returns an appropriately quoted sequence value for inserting a new row.
22602260 * MySQL has autoincrement fields, so this is just NULL. But the PostgreSQL
22612261 * subclass will return an integer, and save the value for insertId()
 2262+ *
 2263+ * Any implementation of this function should *not* involve reusing
 2264+ * sequence numbers created for rolled-back transactions.
 2265+ * See http://bugs.mysql.com/bug.php?id=30767 for details.
22622266 */
22632267 function nextSequenceValue( $seqName ) {
22642268 return null;

Status & tagging log