r102855 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102854‎ | r102855 | r102856 >
Date:11:06, 12 November 2011
Author:catrope
Status:ok
Tags:
Comment:
[RL2] Followup r102817: move the old title message to -desc instead of -title, because it's often long and contains wikitext. Also remove a var_dump that snuck in in r102854
Modified paths:
  • /branches/RL2/extensions/Gadgets/migrateGadgets.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/migrateGadgets.php
@@ -50,8 +50,8 @@
5151
5252 $this->output( "Converting $id ...\n" );
5353 $moves = array(
54 - "MediaWiki:Gadget-$id" => "MediaWiki:Gadget-$id-title",
55 - "MediaWiki talk:Gadget-$id" => "MediaWiki talk:Gadget-$id-title"
 54+ "MediaWiki:Gadget-$id" => "MediaWiki:Gadget-$id-desc",
 55+ "MediaWiki talk:Gadget-$id" => "MediaWiki talk:Gadget-$id-desc"
5656 );
5757 foreach ( array_merge( $gadget['module']['scripts'], $gadget['module']['styles'] ) as $page ) {
5858 $moves["MediaWiki:Gadget-$page"] = "Gadget:$page";
@@ -230,7 +230,6 @@
231231 $subpages = $title->getSubpages();
232232 foreach ( $subpages as $subpage ) {
233233 $fromSub = $subpage->getPrefixedText();
234 - //var_dump($fromSub);
235234 $toSub = preg_replace( '/^' . preg_quote( $fromNormalized, '/' ) . '/',
236235 StringUtils::escapeRegexReplacement( $to ), $fromSub
237236 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102817[RL2] Add maintenance script for migrating old-style gadgets to the new style...catrope21:49, 11 November 2011
r102854[RL2] Followup r102817: also move the talk page of the title message, and mov...catrope10:37, 12 November 2011

Status & tagging log