r102853 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102852‎ | r102853 | r102854 >
Date:10:06, 12 November 2011
Author:ialex
Status:deferred
Tags:
Comment:
Update the patch so that it stop showing deprecated globals when grepping for them in extensions (also removed extra whitespaces added through the patch)
Modified paths:
  • /trunk/extensions/MetavidWiki/README (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/README
@@ -11,49 +11,39 @@
1212 ==Install==
1313
1414 patches to the core:
15 -Index: /includes/Article.php
 15+Index: /includes/WikiPage.php
1616 //set up transaction for LinksUpdate
1717 $dbw = wfGetDB( DB_MASTER );
18 - $dbw->begin();
19 -
 18+ $dbw->begin();
 19+
2020 # Update the links tables
2121 $u = new LinksUpdate( $this->mTitle, $editInfo->output );
2222 $u->doUpdate();
23 -
 23+
2424 $dbw->commit();
2525
2626 .patch:
27 -Index: /includes/Article.php
 27+Index: includes/WikiPage.php
2828 ===================================================================
29 -+++ /includes/Article.php (working copy)
30 -@@ -2723,7 +2723,7 @@
31 - function editUpdates( $text, $summary, $minoredit, $timestamp_of_pagechange, $newid, $changed = true ) {
32 - global $wgDeferredUpdateList, $wgMessageCache, $wgUser, $wgParser, $wgEnableParserCache;
 29+--- includes/WikiPage.php (revision 102848)
 30+@@ -2028,10 +2028,16 @@
 31+ $parserCache->save( $editInfo->output, $this, $editInfo->popts );
 32+ }
3333
34 -- wfProfileIn( __METHOD__ );
35 -+ wfProfileIn( __METHOD__ );
 34++ //set up transaction for LinksUpdate
 35++ $dbw = wfGetDB( DB_MASTER );
 36++ $dbw->begin();
 37++
 38+ # Update the links tables
 39+ $u = new LinksUpdate( $this->mTitle, $editInfo->output );
 40+ $u->doUpdate();
3641
37 - # Parse the text
38 - # Be careful not to double-PST: $text is usually already PST-ed once
39 -@@ -2740,11 +2740,15 @@
40 - $parserCache = ParserCache::singleton();
41 - $parserCache->save( $editInfo->output, $this, $wgUser );
42 - }
43 --
44 -+ //set up transaction for LinksUpdate
45 -+ $dbw = wfGetDB( DB_MASTER );
46 -+ $dbw->begin();
47 -+
48 - # Update the links tables
49 - $u = new LinksUpdate( $this->mTitle, $editInfo->output );
50 - $u->doUpdate();
51 --
52 -+
53 -+ $dbw->commit();
54 - if( wfRunHooks( 'ArticleEditUpdatesDeleteFromRecentchanges', array( &$this ) ) ) {
55 - if ( 0 == mt_rand( 0, 99 ) ) {
56 - // Flush old entries from the `recentchanges` table; we do this on
 42++ $dbw->commit();
 43++
 44+ wfRunHooks( 'ArticleEditUpdates', array( &$this, &$editInfo, $options['changed'] ) );
 45+
 46+ if ( wfRunHooks( 'ArticleEditUpdatesDeleteFromRecentchanges', array( &$this ) ) ) {
5747
5848
5949
@@ -118,4 +108,4 @@
119109
120110 ===sql that must be run on install===
121111 Run the sql: maintenance/mv_tables.sql
122 - having a web based install is on the todo list ;)
\ No newline at end of file
 112+ having a web based install is on the todo list ;)

Status & tagging log