r102771 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102770‎ | r102771 | r102772 >
Date:12:16, 11 November 2011
Author:santhosh
Status:ok
Tags:
Comment:
While resetting font-family , remove font-family attribute instead of setting to None.

As reported at https://www.mediawiki.org/wiki/User:Krinkle/Extension_review/WebFonts#font-family:none
Modified paths:
  • /trunk/extensions/WebFonts/resources/ext.webfonts.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/resources/ext.webfonts.js
@@ -64,7 +64,7 @@
6565 $( 'input, select' ).css( 'font-family', mw.webfonts.oldconfig.fontFamily );
6666
6767 // Reset the fonts applied for tags with lang attribute.
68 - $( '.webfonts-lang-attr' ).css( 'font-family', 'none' ).removeClass( 'webfonts-lang-attr' );
 68+ $( '.webfonts-lang-attr' ).css( 'font-family', '' ).removeClass( 'webfonts-lang-attr' );
6969
7070 // Remove the cookie
7171 $.cookie( 'webfonts-font', 'none', { 'path': '/', 'expires': 30 } );

Status & tagging log