r102761 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102760‎ | r102761 | r102762 >
Date:08:10, 11 November 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
ie fixes
Modified paths:
  • /trunk/extensions/Survey/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/Survey/resources/ext.survey.special.survey.js (modified) (history)
  • /trunk/extensions/Survey/resources/jquery.survey.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Survey/RELEASE-NOTES
@@ -8,6 +8,7 @@
99 2011-xx-xx
1010
1111 * Fixed issue with database index names causing update.php to fail when running after installation of Survey.
 12+* Fixed several IE JavaScript issues.
1213
1314 === Version 0.1.1 ===
1415 2011-09-18
Index: trunk/extensions/Survey/resources/ext.survey.special.survey.js
@@ -172,7 +172,7 @@
173173 'required': $this.attr( 'data-required' ) == '1',
174174 'id': $this.attr( 'data-id' ),
175175 'type': $this.attr( 'data-type' ),
176 - 'answers': eval( $this.attr( 'data-answers' ) ),
 176+ 'answers': eval( $this.attr( 'data-answers' ) )
177177 } );
178178 } );
179179
@@ -183,4 +183,4 @@
184184
185185 setup();
186186
187 -} ); })( jQuery, window.mediaWiki, window.survey );
\ No newline at end of file
 187+} ); })( jQuery, window.mediaWiki, window.survey );
Index: trunk/extensions/Survey/resources/jquery.survey.js
@@ -26,7 +26,7 @@
2727 };
2828
2929 if ( options.requireEnabled ) {
30 - requestArgs['suenabled'] = 1;
 30+ requestArgs.suenabled = 1;
3131 }
3232
3333 requestArgs[ 'su' + this.identifierType + 's' ] = this.identifier;
@@ -111,7 +111,7 @@
112112 $input = $( '<input />' ).attr( {
113113 'id': id,
114114 'type': 'checkbox',
115 - 'class': 'question-input survey-check',
 115+ 'class': 'question-input survey-check'
116116 } );
117117 break;
118118 }
@@ -257,7 +257,7 @@
258258 } ).html( $( '<div />' ).attr( { 'id': 'survey-' + surveyData.id } ).html( this.getSurveyBody( surveyData ) ) );
259259
260260 $link = $( '<a />' ).attr( {
261 - 'href': '#survey-' + surveyData.id,
 261+ 'href': '#survey-' + surveyData.id
262262 } ).html( $div );
263263
264264 $( this ).html( $link );

Status & tagging log