r102676 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102675‎ | r102676 | r102677 >
Date:19:34, 10 November 2011
Author:yaron
Status:deferred
Tags:
Comment:
Follow-up to r102365 - changed comparator to check for null, instead of blank
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormLinker.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormLinker.php
——@@ -287,7 +287,7 @@
288288 }
289289 self::createLinkedPage( $target, $incoming_properties );
290290 $link = self::formEditLink( $target, $incoming_properties );
291 - if ( $link !== '' ) {
 291+ if ( !is_null( $link ) ) {
292292 $attribs['href'] = $link;
293293 }
294294 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102365strict comparators for empty stringsjeroendedauw02:25, 8 November 2011