r102626 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102625‎ | r102626 | r102627 >
Date:07:46, 10 November 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Quantity.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_WikiPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Quantity.php
@@ -120,7 +120,7 @@
121121 if ( !is_null( $this->m_property ) ) {
122122 $propertyDiWikiPage = $this->m_property->getDiWikiPage();
123123 }
124 - if ( is_null( $this->m_property ) || is_null( $propertyDiWikiPag ) ) {
 124+ if ( is_null( $this->m_property ) || is_null( $propertyDiWikiPage ) ) {
125125 return; // we cannot find conversion factors without the property
126126 }
127127
Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_WikiPage.php
@@ -145,10 +145,12 @@
146146 $this->m_fragment = $dataItem->getSubobjectName();
147147 $this->m_prefixedtext = '';
148148 $this->m_caption = false; // this class can handle this
 149+
149150 if ( ( $this->m_fixNamespace != NS_MAIN ) &&
150151 ( $this->m_fixNamespace != $dataItem->getNamespace() ) ) {
151 - $this->addError( wfMsgForContent( 'smw_wrong_namespace',
152 - $wgContLang->getNsText( $this->m_fixNamespace ) ) );
 152+ global $wgContLang;
 153+ $this->addError( wfMsgForContent( 'smw_wrong_namespace',
 154+ $wgContLang->getNsText( $this->m_fixNamespace ) ) );
153155 }
154156 return true;
155157 } else {

Status & tagging log