r102588 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102587‎ | r102588 | r102589 >
Date:22:51, 9 November 2011
Author:reedy
Status:ok
Tags:
Comment:
1.18wmf1 MFT r92846, r98764, r99477
Modified paths:
  • /branches/wmf/1.18wmf1 (modified) (history)
  • /branches/wmf/1.18wmf1/includes (modified) (history)
  • /branches/wmf/1.18wmf1/includes/Wiki.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/media (modified) (history)
  • /branches/wmf/1.18wmf1/includes/media/JpegMetadataExtractor.php (modified) (history)
  • /branches/wmf/1.18wmf1/resources/jquery.ui/themes/vector/jquery.ui.button.css (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/media/JpegMetadataExtractor.php
@@ -58,7 +58,7 @@
5959 throw new MWException( 'Too many jpeg segments. Aborting' );
6060 }
6161 if ( $buffer !== "\xFF" ) {
62 - throw new MWException( "Error reading jpeg file marker" );
 62+ throw new MWException( "Error reading jpeg file marker. Expected 0xFF but got " . bin2hex( $buffer ) );
6363 }
6464
6565 $buffer = fread( $fh, 1 );
@@ -123,6 +123,9 @@
124124 } elseif ( $buffer === "\xD9" || $buffer === "\xDA" ) {
125125 // EOI - end of image or SOS - start of scan. either way we're past any interesting segments
126126 return $segments;
 127+ } elseif ( $buffer === "\xFF" ) {
 128+ // Padding byte. Skip.
 129+ continue;
127130 } else {
128131 // segment we don't care about, so skip
129132 $size = wfUnpack( "nint", fread( $fh, 2 ), 2 );
Property changes on: branches/wmf/1.18wmf1/includes/media
___________________________________________________________________
Modified: svn:mergeinfo
130133 Merged /trunk/phase3/includes/media:r99477
Index: branches/wmf/1.18wmf1/includes/Wiki.php
@@ -147,8 +147,10 @@
148148 array( &$title, null, &$output, &$user, $request, $this ) );
149149
150150 // Invalid titles. Bug 21776: The interwikis must redirect even if the page name is empty.
151 - if ( is_null( $title ) || ( ( $title->getDBkey() == '' ) && ( $title->getInterwiki() == '' ) ) ) {
152 - $this->context->title = SpecialPage::getTitleFor( 'Badtitle' );
 151+ if ( is_null( $title ) || ( $title->getDBkey() == '' && $title->getInterwiki() == '' ) ||
 152+ $title->isSpecial( 'Badtitle' ) )
 153+ {
 154+ $this->context->setTitle( SpecialPage::getTitleFor( 'Badtitle' ) );
153155 // Die now before we mess up $wgArticle and the skin stops working
154156 throw new ErrorPageError( 'badtitle', 'badtitletext' );
155157 // If the user is not logged in, the Namespace:title of the article must be in
Property changes on: branches/wmf/1.18wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
156158 Merged /trunk/phase3/includes:r98764,99477
Index: branches/wmf/1.18wmf1/resources/jquery.ui/themes/vector/jquery.ui.button.css
@@ -9,22 +9,22 @@
1010
1111 /*button text element */
1212 .ui-button .ui-button-text { display: block; line-height: 1.4em; }
13 -.ui-button-text-only .ui-button-text { padding: .125em .25em; }
14 -.ui-button-icon-only .ui-button-text, .ui-button-icons-only .ui-button-text { padding: .4em; text-indent: -9999999px; }
15 -.ui-button-text-icon-primary .ui-button-text { padding: 0.1em 0.8em 0.1em 1.9em; }
16 -.ui-button-text-icon-secondary .ui-button-text { padding: .1em 1.9em .1em 0.8em; }
17 -.ui-button-text-icons .ui-button-text { padding: 0.1em 1.9em 0.1em 1.9em; }
 13+.ui-button-text-only .ui-button-text { padding: 0.3em 1em 0.25em 1em; }
 14+.ui-button-icon-only .ui-button-text, .ui-button-icons-only .ui-button-text { padding: 0.3em; text-indent: -9999999px; }
 15+.ui-button-text-icon-primary .ui-button-text, .ui-button-text-icons .ui-button-text { padding: 0.3em 1em 0.25em 2.1em; }
 16+.ui-button-text-icon-secondary .ui-button-text, .ui-button-text-icons .ui-button-text { padding: 0.3em 2.1em 0.25em 1em; }
 17+.ui-button-text-icons .ui-button-text { padding-left: 2.1em; padding-right: 2.1em; }
1818 /* for older versions of jQuery UI */
19 -.ui-button-text-icon .ui-button-text { padding: 0.1em 0.8em 0.1em 1.9em; }
 19+.ui-button-text-icon .ui-button-text { padding: 0.3em 1em 0.3em 2.1em; }
2020
2121 /* no icon support for input elements, provide padding by default */
22 -input.ui-button { padding: .4em 1em; }
 22+input.ui-button { padding: 0.3em 1em; }
2323
2424 /*button icon element(s) */
2525 .ui-button-icon-only .ui-icon, .ui-button-text-icon-primary .ui-icon, .ui-button-text-icon-secondary .ui-icon, .ui-button-text-icons .ui-icon, .ui-button-text-icon .ui-icon, .ui-button-icons-only .ui-icon { position: absolute; top: 50%; margin-top: -9px; }
2626 .ui-button-icon-only .ui-icon { left: 50%; margin-left: -8px; }
27 -.ui-button-text-icon-primary .ui-button-icon-primary, .ui-button-text-icon .ui-button-icon-primary, .ui-button-text-icons .ui-button-icon-primary, .ui-button-icons-only .ui-button-icon-primary { left: 0; }
28 -.ui-button-text-icon-secondary .ui-button-icon-secondary, .ui-button-text-icon .ui-button-icon-secondary, .ui-button-text-icons .ui-button-icon-secondary, .ui-button-icons-only .ui-button-icon-secondary { right: 16px; }
 27+.ui-button-text-icon-primary .ui-button-icon-primary, .ui-button-text-icon .ui-button-icon-primary, .ui-button-text-icons .ui-button-icon-primary, .ui-button-icons-only .ui-button-icon-primary { left: 0.5em; }
 28+.ui-button-text-icon-secondary .ui-button-icon-secondary, .ui-button-text-icon .ui-button-icon-secondary, .ui-button-text-icons .ui-button-icon-secondary, .ui-button-icons-only .ui-button-icon-secondary { right: 0.5em; }
2929
3030 /*button sets*/
3131 .ui-buttonset { margin-right: 7px; }
@@ -36,7 +36,7 @@
3737 body .ui-button {
3838 -moz-border-radius: 4px;
3939 -webkit-border-radius: 4px;
40 - padding: 0.2em 0.6em 0.15em !important;
 40+ border-radius: 4px;
4141 margin: 0.5em 0 0.5em 0.4em !important;
4242 border: 1px solid #a6a6a6 !important;
4343 /* @embed */
Property changes on: branches/wmf/1.18wmf1
___________________________________________________________________
Modified: svn:mergeinfo
4444 Merged /trunk/phase3:r92846,98764,99477

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92846follow-up to r91499 - set padding for the elements inside the button rather t...kaldari02:11, 22 July 2011
r98764Also catch Special:Badtitle to display the "Bad title" error message since th...ialex14:04, 3 October 2011
r99477(bug 31588, sort of) Jpeg metadata code wasn't handling padding bytes properly....bawolff14:05, 11 October 2011

Status & tagging log