r102535 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102534‎ | r102535 | r102536 >
Date:17:12, 9 November 2011
Author:hashar
Status:ok
Tags:
Comment:
MFT to REL1_18 r101002

(bug 29912) Unit tests break if parsertest tables are still present

I need that to run the test suite in 1.18
Modified paths:
  • /branches/REL1_18/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/REL1_18/phase3/tests/parser/parserTest.inc (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/RELEASE-NOTES-1.18
——@@ -491,6 +491,7 @@
492492 * (bug 31822) Error during upgrade due to output buffer reset in stdout
493493 * (bug 31913) Special:MostLinkedTemplates had an incorrect GROUP BY clause
494494 under Microsoft SQL.
 495+* (bug 29912) Unit tests break if parsertest tables are still present
495496
496497 === API changes in 1.18 ===
497498 * BREAKING CHANGE: action=watch now requires POST and token.
Index: branches/REL1_18/phase3/tests/parser/parserTest.inc
——@@ -858,6 +858,13 @@
859859 $this->databaseSetupDone = false;
860860
861861 if ( $this->useTemporaryTables ) {
 862+ if( $this->db->getType() == 'sqlite' ) {
 863+ # Under SQLite the searchindex table is virtual and need
 864+ # to be explicitly destroyed. See bug 29912
 865+ # See also MediaWikiTestCase::destroyDB()
 866+ wfDebug( __METHOD__ . " explicitly destroying sqlite virtual table parsertest_searchindex\n" );
 867+ $this->db->query( "DROP TABLE `parsertest_searchindex`" );
 868+ }
862869 # Don't need to do anything
863870 $this->teardownGlobals();
864871 return;
Property changes on: branches/REL1_18/phase3/tests/parser/parserTest.inc
___________________________________________________________________
Added: svn:mergeinfo
865872 Merged /branches/REL1_15/phase3/tests/parser/parserTest.inc:r51646
866873 Merged /branches/wmf/1.18wmf1/tests/parser/parserTest.inc:r97604,98962,98971,99004,99065
867874 Merged /branches/REL1_17/phase3/tests/parser/parserTest.inc:r81445,81448
868875 Merged /branches/sqlite/tests/parser/parserTest.inc:r58211-58321
869876 Merged /trunk/phase3/tests/parser/parserTest.inc:r92580,92634,92713,92762,92765,92791,92846,92854,92884,92886-92887,92894,92898,92907,92932,92958,93065,93141,93149,93151,93233-93234,93258,93266,93303,93516-93518,93520,93726,93818-93822,93834,93847,93858,93891,93935-93936,93977,94058,94062,94068,94107,94155,94171,94199,94235,94277,94346,94372,94422,94425,94444,94448,94456,94498,94517,94601,94630,94728,94738,94825,94862,94867,94995-94997,95023,95042,95072-95073,95155,95163,95327,95332,95410,95422,95426,95442,95468,95601,95812,96178,96182,96437-96438,96579,97291,97806,97815,97821,97895,98069,98193-98194,98210,98212,98235,98237,98298,98374,98379,98411,98426,98502,98602-98603,98605,98610,98612,98656,98665,98669,98676,98678,98703,98707,98713,98716,98718-98720,98755-98756,98760-98761,98774,98812,98880,98884,98927,98963,98975,98990,98997,99031,99081-99082,99091-99092,99102,99104,99118,99126,99135-99136,99138,99154,99172,99250,99252,99254,99286,99304,99308,99318,99321,99323,99332,99349,99353,99369-99371,99396,99477,99630,99632,99653,99680,99694,99700,99897,99910,99914,99931,99952,99994,100021,100115,100211,100219,100221,100223,100226,100239,100242,100347,100391,100398,100510,100572,100575-100576,100592,100701,101002,101010,101306,101449-101451,101454
870877 Merged /branches/new-installer/phase3/tests/parser/parserTest.inc:r43664-66004

Follow-up revisions

RevisionCommit summaryAuthorDate
r102536move bug 29912 RN form 1.19 to 1.18...hashar17:14, 9 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101002parsertest now destroy virtual table under SQLite...hashar17:12, 27 October 2011

Status & tagging log