r102503 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102502‎ | r102503 | r102504 >
Date:10:01, 9 November 2011
Author:tstarling
Status:ok
Tags:
Comment:
Merged r102502 from 1.18wmf1
Modified paths:
  • /trunk/extensions/ExtensionDistributor (modified) (history)
  • /trunk/extensions/ExtensionDistributor/svn-invoker.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ExtensionDistributor/svn-invoker.php
@@ -65,16 +65,12 @@
6666 svnError( 'extdist-remote-error', "Unable to open lock file." );
6767 return;
6868 }
69 - $timeout = 20;
 69+ $timeout = 3;
7070 for ( $i = 0; $i < $timeout; $i++ ) {
7171 $wouldBlock = false;
7272 if ( flock( $lockFile, LOCK_EX | LOCK_NB ) ) {
7373 break;
7474 }
75 - if ( !$wouldBlock ) {
76 - svnError( 'extdist-remote-error', "Error attempting to obtain lock." );
77 - return;
78 - }
7975 sleep( 1 );
8076 }
8177 if ( $i == $timeout ) {
Property changes on: trunk/extensions/ExtensionDistributor
___________________________________________________________________
Modified: svn:mergeinfo
8278 Merged /branches/wmf/1.18wmf1/extensions/ExtensionDistributor:r102502

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102502More fixes for r102482: the $wouldBlock check doesn't appear to work, also do...tstarling09:59, 9 November 2011

Status & tagging log