r102491 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102490‎ | r102491 | r102492 >
Date:04:13, 9 November 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
Follow up to r102490;
Modified paths:
  • /trunk/extensions/Contest/Contest.i18n.php (modified) (history)
  • /trunk/extensions/Contest/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialContestWelcome.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/Contest.i18n.php
@@ -356,6 +356,8 @@
357357 'contest-mycontests-sessionfail' => 'Session failure',
358358 'contest-submission-challenge' => 'Tells the user which challenge they are part of. $1 is the challenge name',
359359 'contest-submission-challenge-description' => 'Output of challenge name and description. $1 is the challenge name, $2 is the challenge description',
 360+ 'contest-welcome-active-contests' => 'Message shown above a list of contests',
 361+ 'contest-welcome-no-contests-active' => 'Indicates that there arte no active contests',
360362 );
361363
362364 /** толышә зывон (толышә зывон)
Index: trunk/extensions/Contest/specials/SpecialContestWelcome.php
@@ -59,6 +59,16 @@
6060 }
6161 }
6262
 63+ /**
 64+ * Handle requests for non-existing contests, or requests with no contest specified.
 65+ * If the contest does not exist, an error is shown, unless there is only one existing
 66+ * contest, in which case the user is redirected to it, which also happens when no contest
 67+ * is specified. If there are multiple active contests, a list is shown.
 68+ *
 69+ * @since 0.2
 70+ *
 71+ * @param string $subPage
 72+ */
6373 protected function showNoSuchContest( $subPage ) {
6474 $out = $this->getOutput();
6575
Index: trunk/extensions/Contest/RELEASE-NOTES
@@ -7,6 +7,7 @@
88 === Version 0.2 ===
99
1010 * Added filter options for the contestant pager on Special:Contest.
 11+* Added nicer handling of requests of non-existing contests on Special:ContestWelcome.
1112
1213 === Version 0.1 ===
1314 2011-10-20

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102490address bug 32261jeroendedauw04:05, 9 November 2011

Status & tagging log