r102481 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102480‎ | r102481 | r102482 >
Date:02:27, 9 November 2011
Author:yaron
Status:reverted
Tags:
Comment:
Partial revert of r102368 - I'm pretty sure the additional is_null() checks aren't necessary
Modified paths:
  • /trunk/extensions/SemanticForms/specials/SF_FormStart.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_FormStart.php
@@ -65,7 +65,7 @@
6666 // This form can be used to create a sub-page for an
6767 // existing page
6868
69 - if ( !is_null( $super_page ) && $super_page !== '' ) {
 69+ if ( $super_page !== '' ) {
7070 $page_name = "$super_page/$page_name";
7171 }
7272
@@ -173,7 +173,7 @@
174174 }
175175 }
176176
177 - if ( !is_null( $params ) && $params !== '' ) {
 177+ if ( $params !== '' ) {
178178 $redirect_url .= ( strpos( $redirect_url, '?' ) > - 1 ) ? '&' : '?';
179179 $redirect_url .= $params;
180180 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r102484Fix for r102368 - apparently, the is_null() check was necessary; replaced the...yaron02:48, 9 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102368Follow up to r102365;jeroendedauw02:46, 8 November 2011

Status & tagging log