r102423 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102422‎ | r102423 | r102424 >
Date:19:10, 8 November 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
bugfix (textarea with autocomplete crashes without source name); bugfix (parameter post button produces get form)
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php
@@ -256,7 +256,7 @@
257257 );
258258 } elseif ( $inLinkType == 'post button' ) {
259259 $str =
260 - Xml::tags( 'form', array('action' => $link_url, 'method' => 'get', 'class' => $classStr),
 260+ Xml::tags( 'form', array('action' => $link_url, 'method' => 'post', 'class' => $classStr),
261261 Xml::tags( 'button', array('type' => 'submit', 'value' => $inLinkStr), $inLinkStr ) .
262262 $hidden_inputs
263263 );
Index: trunk/extensions/SemanticForms/includes/SF_Utils.php
@@ -616,6 +616,11 @@
617617 * type, for use by both Javascript autocompletion and comboboxes.
618618 */
619619 public static function getAutocompleteValues( $source_name, $source_type ) {
 620+
 621+ if ( $source_name == null ) {
 622+ return null;
 623+ }
 624+
620625 $names_array = array();
621626 // The query depends on whether this is a property, category,
622627 // concept or namespace.