r102340 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102339‎ | r102340 | r102341 >
Date:22:38, 7 November 2011
Author:inez
Status:deferred
Tags:
Comment:
Add CSS class 'es-viewBranchNode-firstChild' to all first childs of ViewBranchNode
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/bases/es.DocumentViewBranchNode.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/bases/es.DocumentViewBranchNode.js
@@ -48,8 +48,10 @@
4949 this.children.push( childView );
5050 // Update DOM
5151 this.$.append( childView.$ );
 52+ // TODO: adding and deleting classes has to be implemented for unshift, shift, splice, sort
 53+ // and reverse as well
5254 if ( this.children.length === 1 ) {
53 - childView.$.addClass('es-ViewBranchNode-firstChild');
 55+ childView.$.addClass('es-viewBranchNode-firstChild');
5456 }
5557 this.emit( 'afterPush', childView );
5658 this.emit( 'update' );

Status & tagging log