r102304 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102303‎ | r102304 | r102305 >
Date:17:50, 7 November 2011
Author:mah
Status:ok
Tags:
Comment:
re Bug #29283, r101507: Apply Vitaliy Filippov's followup fix:

.... I've found another bug with the implementation - it also
relies on the presence of key '...:preload' and doesn't check it
when checking for the expired cache, which can lead to "Invalid or
missing localisation cache" exceptions.
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
——@@ -357,8 +357,9 @@
358358
359359 $deps = $this->store->get( $code, 'deps' );
360360 $keys = $this->store->get( $code, 'list', 'messages' );
361 - // 'list:messages' sometimes expires separately of 'deps' in LCStore_Accel
362 - if ( $deps === null || $keys === null ) {
 361+ $preload = $this->store->get( $code, 'preload' );
 362+ // Different keys may expire separately, at least in LCStore_Accel
 363+ if ( $deps === null || $keys === null || $preload === null ) {
363364 wfDebug( __METHOD__."($code): cache missing, need to make one\n" );
364365 return true;
365366 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101492Apply Vitaliy Filippov's patch from Bug #29283 with some small style modsmah16:10, 1 November 2011
r101507Re-apply Vitaliy Filippov's patch from Bug #29283 with a modification...mah18:31, 1 November 2011

Status & tagging log