r102292 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102291‎ | r102292 | r102293 >
Date:15:50, 7 November 2011
Author:ashley
Status:ok
Tags:
Comment:
SocialProfile: follow-up to r102132 as per Nikerabbit's code review: use OutputPage's addWikiMsg() instead of addHTML() + wfMsgExt()
Modified paths:
  • /trunk/extensions/SocialProfile/UserStats/SpecialUpdateEditCounts.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserStats/SpecialUpdateEditCounts.php
@@ -73,13 +73,10 @@
7474 __METHOD__
7575 );
7676 }
77 - $wgOut->addHTML(
78 - wfMsgExt(
79 - 'updateeditcounts-updating',
80 - 'parsemag',
81 - $row->rev_user_text,
82 - $editCount
83 - )
 77+ $wgOut->addWikiMsg(
 78+ 'updateeditcounts-updating',
 79+ $row->rev_user_text,
 80+ $editCount
8481 );
8582
8683 $dbw->update(
@@ -144,6 +141,6 @@
145142 $stats->updateTotalPoints();
146143 }
147144
148 - $wgOut->addHTML( wfMsgExt( 'updateeditcounts-updated', 'parsemag', $x ) );
 145+ $wgOut->addWikiMsg( 'updateeditcounts-updated', $x );
149146 }
150147 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102132SocialProfile: as per Markus' in-depth review:...ashley00:17, 6 November 2011

Status & tagging log