r102283 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102282‎ | r102283 | r102284 >
Date:13:54, 7 November 2011
Author:ialex
Status:ok
Tags:
Comment:
Removed useless second parameter to Title::quickUserCan()
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/TitlePermissionTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/TitlePermissionTest.php
@@ -309,7 +309,7 @@
310310 $this->assertEquals( $check[$action][3],
311311 $this->title->userCan( $action, true ) );
312312 $this->assertEquals( $check[$action][3],
313 - $this->title->quickUserCan( $action, false ) );
 313+ $this->title->quickUserCan( $action ) );
314314
315315 # count( User::getGroupsWithPermissions( $action ) ) < 1
316316 }
@@ -461,7 +461,7 @@
462462 $this->user ) );
463463
464464 $this->assertEquals( true,
465 - $this->title->quickUserCan( 'edit', false ) );
 465+ $this->title->quickUserCan( 'edit' ) );
466466 $this->title->mRestrictions = array( "edit" => array( 'bogus', "sysop", "protect", "" ),
467467 "bogus" => array( 'bogus', "sysop", "protect", "" ) );
468468
@@ -501,9 +501,9 @@
502502 $this->user ) );
503503 $this->title->mCascadeRestriction = true;
504504 $this->assertEquals( false,
505 - $this->title->quickUserCan( 'bogus', false ) );
 505+ $this->title->quickUserCan( 'bogus' ) );
506506 $this->assertEquals( false,
507 - $this->title->quickUserCan( 'edit', false ) );
 507+ $this->title->quickUserCan( 'edit' ) );
508508 $this->assertEquals( array( array( 'badaccess-group0' ),
509509 array( 'protectedpagetext', 'bogus' ),
510510 array( 'protectedpagetext', 'protect' ),

Status & tagging log