r102153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102152‎ | r102153 | r102154 >
Date:04:46, 6 November 2011
Author:cryptocoryne
Status:deferred
Tags:
Comment:
Followup r102139: fix some critical error
Modified paths:
  • /trunk/extensions/Premoderation/Premoderation.class.php (modified) (history)
  • /trunk/extensions/Premoderation/SpecialPremoderation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Premoderation/SpecialPremoderation.php
@@ -160,9 +160,9 @@
161161 }
162162
163163 $rev = Revision::newFromID( $row['pmq_page_last_id'] );
164 - $diff = new DifferenceEngine( $rev->getTitle() );
 164+ $diff = new DifferenceEngine();
165165 $diff->showDiffStyle();
166 - $formattedDiff = $diff->generateDiffBody( $rev->getText(), $row['pmq_text'] );
 166+ $formattedDiff = $diff->generateDiffBody( isset( $rev ) ? $rev->getText() : '', $row['pmq_text'] );
167167
168168 $wgOut->addHTML( '<h2>' . wfMsg( 'premoderation-diff-h2' ) . '</h2>' .
169169 "<table class='mw-abusefilter-diff-multiline'><col class='diff-marker' />" .
Index: trunk/extensions/Premoderation/Premoderation.class.php
@@ -105,6 +105,8 @@
106106 }
107107
108108 public static function checkWhitelist( $ip ) {
 109+ global $wgMemc;
 110+
109111 $whitelist = self::loadWhitelist();
110112
111113 $memcKey = wfMemcKey( 'whitelisted', $ip );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102139Added experimental version of new extensioncryptocoryne01:17, 6 November 2011

Status & tagging log