r102103 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102102‎ | r102103 | r102104 >
Date:15:25, 5 November 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
followup r102060: remove double-escaping
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php
@@ -612,7 +612,7 @@
613613 // To do that they need to use htmlentities instead of
614614 // braces and brackets
615615 $formcontent .=
616 - Xml::input( $key, false, htmlentities( html_entity_decode( $value ) ) , array( 'type' => 'hidden') );
 616+ Xml::input( $key, false, Sanitizer::decodeCharReferences( $value ) , array( 'type' => 'hidden' ) );
617617 }
618618 }
619619
@@ -631,7 +631,7 @@
632632 }
633633
634634 $formcontent .=
635 - Xml::input( 'wpSummary', false, urldecode( $summary ), array('type' => 'hidden') );
 635+ Xml::input( 'wpSummary', false, $summary, array('type' => 'hidden') );
636636
637637 $form = Xml::tags( 'form', array( 'class' => 'autoedit-data' ), $formcontent );
638638

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102060bugfix (#autoedit not able to update a field with a +)foxtrott22:27, 4 November 2011