r102039 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102038‎ | r102039 | r102040 >
Date:20:17, 4 November 2011
Author:catrope
Status:deferred
Tags:
Comment:
Change something that appeared to be a bug in the removal code
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/models/es.DocumentModel.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/models/es.DocumentModel.js
@@ -1072,7 +1072,7 @@
10731073 } else if ( op.type === 'remove' ) {
10741074 // we add one because to remove(3,5) we need to slice(3,6), the ending is last
10751075 // subscript removed + 1.
1076 - tx.pushRemove( this.data.slice( op.start, op.end + 1 ) );
 1076+ tx.pushRemove( doc.data.slice( op.start, op.end + 1 ) );
10771077 } else {
10781078 console.log( "this is impossible" );
10791079 }

Status & tagging log