r102034 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r102033‎ \| r102034 \| r102035 >
Date:	19:50, 4 November 2011
Author:	jpostlethwaite
Status:	deferred
Tags:	fundraising
Comment:	Updated selenium unit tests.
Modified paths:	/trunk/extensions/DonationInterface/tests/macros/form.globalcollect.webitects_2_3step.htm (modified) (history) /trunk/extensions/DonationInterface/tests/macros/form.twostepamount.banktransfer.netherlands.htm (modified) (history) /trunk/extensions/DonationInterface/tests/macros/form.twostepamount.banktransfer.spain.htm (modified) (history) /trunk/extensions/DonationInterface/tests/macros/suite-all-payment-gateways.htm (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/tests/macros/suite-all-payment-gateways.htm
—	—	@@ -14,7 +14,7 @@
15	15	<tr><td><a href="form.payflowpro.american.express.htm">form.payflowpro.american.express</a></td></tr>
16	16	<tr><td><a href="form.twostepamount.banktransfer.netherlands.htm">form.twostepamount.banktransfer.netherlands</a></td></tr>
17	17	<tr><td><a href="form.twostepamount.banktransfer.netherlands.fail.not.a.valid.combination.htm">form.twostepamount.banktransfer.netherlands.fail.not.a.valid.combination</a></td></tr>
18		~~-<tr><td><a href="form.twostepamount.banktransfer.netherlands.htm">form.twostepamount.banktransfer.spain</a></td></tr>~~
	18	+<tr><td><a href="form.twostepamount.banktransfer.spain.htm">form.twostepamount.banktransfer.spain</a></td></tr>
19	19	<tr><td><a href="form.twostepamount.directdebit.austria.htm">form.twostepamount.directdebit.austria</a></td></tr>
20	20	<tr><td><a href="form.twostepamount.directdebit.belgium.htm">form.twostepamount.directdebit.belgium</a></td></tr>
21	21	<tr><td><a href="form.twostepamount.directdebit.italy.htm">form.twostepamount.directdebit.italy</a></td></tr>
Index: trunk/extensions/DonationInterface/tests/macros/form.globalcollect.webitects_2_3step.htm
—	—	@@ -13,20 +13,10 @@
14	14	</thead><tbody>
15	15	<tr>
16	16	<td>open</td>
17		~~- <td>/index.php/Special:GlobalCollectGateway?form_name=RapidHtml&ffname=webitects_2_3step&country=US</td>~~
	17	+ <td>/index.php/Special:GlobalCollectGateway</td>
18	18	<td></td>
19	19	</tr>
20	20	<tr>
21		~~- <td>click</td>~~
22		~~- <td>id=amountRadio6</td>~~
23		~~- <td></td>~~
24		~~-</tr>~~
25		~~-<tr>~~
26		~~- <td>click</td>~~
27		~~- <td>id=cc</td>~~
28		~~- <td></td>~~
29		~~-</tr>~~
30		~~-<tr>~~
31	21	<td>type</td>
32	22	<td>id=fname</td>
33	23	<td>Testy</td>
—	—	@@ -49,7 +39,7 @@
50	40	<tr>
51	41	<td>select</td>
52	42	<td>id=state</td>
53		~~- <td>label=CA</td>~~
	43	+ <td>label=California</td>
54	44	</tr>
55	45	<tr>
56	46	<td>type</td>
—	—	@@ -62,23 +52,43 @@
63	53	<td>no-reply@wikimedia.org</td>
64	54	</tr>
65	55	<tr>
66		~~- <td>click</td>~~
67		~~- <td>id=cc-visa</td>~~
68		~~- <td></td>~~
	56	+ <td>type</td>
	57	+ <td>id=card_num</td>
	58	+ <td>4263982640269299</td>
69	59	</tr>
70	60	<tr>
71		~~- <td>click</td>~~
72		~~- <td>id=paymentContinueBtn</td>~~
73		~~- <td></td>~~
	61	+ <td>type</td>
	62	+ <td>id=cvv</td>
	63	+ <td>123</td>
74	64	</tr>
75	65	<tr>
76		~~- <td>click</td>~~
77		~~- <td>id=expertContentHeading</td>~~
	66	+ <td>select</td>
	67	+ <td>id=expiration</td>
	68	+ <td>label=2 (February)</td>
	69	+</tr>
	70	+<tr>
	71	+ <td>select</td>
	72	+ <td>id=year</td>
	73	+ <td>label=2012</td>
	74	+</tr>
	75	+<tr>
	76	+ <td>select</td>
	77	+ <td>id=country</td>
	78	+ <td>label=United States</td>
	79	+</tr>
	80	+<tr>
	81	+ <td>type</td>
	82	+ <td>id=amount</td>
	83	+ <td>50.00</td>
	84	+</tr>
	85	+<tr>
	86	+ <td>clickAndWait</td>
	87	+ <td>css=input.button-plain</td>
78	88	<td></td>
79	89	</tr>
80	90	<tr>
81		~~- <td>click</td>~~
82		~~- <td>id=exceptionDialogButton</td>~~
	91	+ <td>selectFrame</td>
	92	+ <td>globalcollectframe</td>
83	93	<td></td>
84	94	</tr>
85	95	<tr>
—	—	@@ -101,6 +111,11 @@
102	112	<td>id=F1136</td>
103	113	<td>123</td>
104	114	</tr>
	115	+<tr>
	116	+ <td>clickAndWait</td>
	117	+ <td>id=btnSubmit</td>
	118	+ <td></td>
	119	+</tr>
105	120	</tbody></table>
106	121	</body>
107	122	</html>
Index: trunk/extensions/DonationInterface/tests/macros/form.twostepamount.banktransfer.netherlands.htm
—	—	@@ -67,7 +67,22 @@
68	68	<td></td>
69	69	</tr>
70	70	<tr>
	71	+ <td>selectWindow</td>
	72	+ <td>null</td>
	73	+ <td></td>
	74	+</tr>
	75	+<tr>
71	76	<td>verifyTextPresent</td>
	77	+ <td>Bank transfer information</td>
	78	+ <td></td>
	79	+</tr>
	80	+<tr>
	81	+ <td>clickAndWait</td>
	82	+ <td>link=Finished</td>
	83	+ <td></td>
	84	+</tr>
	85	+<tr>
	86	+ <td>verifyTextPresent</td>
72	87	<td>Thank you for your support.</td>
73	88	<td></td>
74	89	</tr>
—	—	@@ -76,6 +91,51 @@
77	92	<td>Thank You/en - Wikimedia Foundation</td>
78	93	<td></td>
79	94	</tr>
	95	+<tr>
	96	+ <td>verifyTextPresent</td>
	97	+ <td>Account holder</td>
	98	+ <td></td>
	99	+</tr>
	100	+<tr>
	101	+ <td>verifyText</td>
	102	+ <td>css=th</td>
	103	+ <td>Account holder</td>
	104	+</tr>
	105	+<tr>
	106	+ <td>verifyTextPresent</td>
	107	+ <td>Bank name</td>
	108	+ <td></td>
	109	+</tr>
	110	+<tr>
	111	+ <td>verifyTextPresent</td>
	112	+ <td>Bank account number</td>
	113	+ <td></td>
	114	+</tr>
	115	+<tr>
	116	+ <td>verifyTextPresent</td>
	117	+ <td>City</td>
	118	+ <td></td>
	119	+</tr>
	120	+<tr>
	121	+ <td>verifyTextPresent</td>
	122	+ <td>Country description</td>
	123	+ <td></td>
	124	+</tr>
	125	+<tr>
	126	+ <td>verifyTextPresent</td>
	127	+ <td>IBAN</td>
	128	+ <td></td>
	129	+</tr>
	130	+<tr>
	131	+ <td>verifyTextPresent</td>
	132	+ <td>Payment reference</td>
	133	+ <td></td>
	134	+</tr>
	135	+<tr>
	136	+ <td>verifyTextPresent</td>
	137	+ <td>Swift code</td>
	138	+ <td></td>
	139	+</tr>
80	140	</tbody></table>
81	141	</body>
82	142	</html>
Index: trunk/extensions/DonationInterface/tests/macros/form.twostepamount.banktransfer.spain.htm
—	—	@@ -29,7 +29,7 @@
30	30	<tr>
31	31	<td>select</td>
32	32	<td>id=country</td>
33		~~- <td>label=Spain</td>~~
	33	+ <td>label=Netherlands</td>
34	34	</tr>
35	35	<tr>
36	36	<td>type</td>
—	—	@@ -59,8 +59,78 @@
60	60	<tr>
61	61	<td>select</td>
62	62	<td>id=input_currency_code</td>
63		~~- <td>label=EUR: Euro</td>~~
	63	+ <td>label=Euro</td>
64	64	</tr>
	65	+<tr>
	66	+ <td>clickAndWait</td>
	67	+ <td>css=input.button-plain</td>
	68	+ <td></td>
	69	+</tr>
	70	+<tr>
	71	+ <td>verifyTextPresent</td>
	72	+ <td>Bank transfer information</td>
	73	+ <td></td>
	74	+</tr>
	75	+<tr>
	76	+ <td>verifyTextPresent</td>
	77	+ <td>Account holder</td>
	78	+ <td></td>
	79	+</tr>
	80	+<tr>
	81	+ <td>verifyText</td>
	82	+ <td>css=th</td>
	83	+ <td>Account holder</td>
	84	+</tr>
	85	+<tr>
	86	+ <td>verifyTextPresent</td>
	87	+ <td>Bank name</td>
	88	+ <td></td>
	89	+</tr>
	90	+<tr>
	91	+ <td>verifyTextPresent</td>
	92	+ <td>Bank account number</td>
	93	+ <td></td>
	94	+</tr>
	95	+<tr>
	96	+ <td>verifyTextPresent</td>
	97	+ <td>City</td>
	98	+ <td></td>
	99	+</tr>
	100	+<tr>
	101	+ <td>verifyTextPresent</td>
	102	+ <td>Country description</td>
	103	+ <td></td>
	104	+</tr>
	105	+<tr>
	106	+ <td>verifyTextPresent</td>
	107	+ <td>IBAN</td>
	108	+ <td></td>
	109	+</tr>
	110	+<tr>
	111	+ <td>verifyTextPresent</td>
	112	+ <td>Payment reference</td>
	113	+ <td></td>
	114	+</tr>
	115	+<tr>
	116	+ <td>verifyTextPresent</td>
	117	+ <td>Swift code</td>
	118	+ <td></td>
	119	+</tr>
	120	+<tr>
	121	+ <td>clickAndWait</td>
	122	+ <td>link=Finished</td>
	123	+ <td></td>
	124	+</tr>
	125	+<tr>
	126	+ <td>verifyTextPresent</td>
	127	+ <td>Thank you for your support.</td>
	128	+ <td></td>
	129	+</tr>
	130	+<tr>
	131	+ <td>assertTitle</td>
	132	+ <td>Thank You/en - Wikimedia Foundation</td>
	133	+ <td></td>
	134	+</tr>
65	135	</tbody></table>
66	136	</body>
67	137	</html>

Status & tagging log

21:39, 9 November 2011 Jpostlethwaite (talk | contribs) changed the tags for r102034 [added: fundraising]
00:05, 5 November 2011 Awjrichards (talk | contribs) changed the status of r102034 [removed: new added: deferred]