r102021 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102020‎ | r102021 | r102022 >
Date:18:31, 4 November 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Prepare removal tests are working now that DocumentModelNode objects have a type property
Modified paths:
  • /trunk/extensions/VisualEditor/tests/es/es.DocumentModel.test.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/tests/es/es.DocumentModel.test.js
@@ -506,7 +506,7 @@
507507 );
508508 } );
509509
510 -test( 'es.DocumentModel.prepareRemoval', 1, function() {
 510+test( 'es.DocumentModel.prepareRemoval', 3, function() {
511511 var documentModel = es.DocumentModel.newFromPlainObject( obj );
512512
513513 // Test 1
@@ -527,7 +527,6 @@
528528 'prepareRemoval includes the content being removed'
529529 );
530530
531 - /*
532531 // Test 2
533532 deepEqual(
534533 documentModel.prepareRemoval( new es.Range( 15, 18 ) ).getOperations(),
@@ -537,7 +536,7 @@
538537 'type': 'remove',
539538 'data': [
540539 { 'type': 'listItem', 'attributes': { 'styles': ['bullet', 'bullet'] } },
541 - 'b',
 540+ 'f',
542541 { 'type': '/listItem' }
543542 ]
544543 },
@@ -562,7 +561,6 @@
563562 ],
564563 'prepareRemoval merges two list items'
565564 );
566 - */
567565 } );
568566
569567 test( 'es.DocumentModel.prepareInsertion', 11, function() {

Status & tagging log