r102001 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102000‎ | r102001 | r102002 >
Date:15:33, 4 November 2011
Author:awjrichards
Status:deferred
Tags:
Comment:
Modified paths:
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects_2_3step.js (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/js/webitects_2_3step.js (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms/js/webitects_2_3step.js
@@ -174,8 +174,11 @@
175175 $( "#change-amount" ).show();
176176 }
177177 function validateAmount() {
 178+
 179+ // TODO: THIS NEEDS TO BE REPLACED WITH KALDARI'S CURRENCIES
178180 var minimums = {
179 - 'USD' : 1
 181+ 'USD' : 1,
 182+ 'CAD' : 1
180183 };
181184 var error = true;
182185 var amount = $( 'input[name="amount"]' ).val(); // get the amount
@@ -189,8 +192,7 @@
190193 error = ( amount == null || isNaN( amount ) || amount.value <= 0 );
191194
192195 // Check amount is at least the minimum
193 - var currency_code = 'USD'; // hard-coded for these forms and tests
194 - $( 'input[name="currency_code"]' ).val( currency_code );
 196+ var currency_code = $( 'input[name="currency_code"]' ).val();
195197 if ( typeof( minimums[currency_code] ) == 'undefined' ) {
196198 minimums[currency_code] = 1;
197199 }
Property changes on: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway/forms
___________________________________________________________________
Modified: svn:mergeinfo
198200 Merged /trunk/extensions/DonationInterface/payflowpro_gateway/forms:r101962
Property changes on: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/payflowpro_gateway
___________________________________________________________________
Modified: svn:mergeinfo
199201 Merged /trunk/extensions/DonationInterface/payflowpro_gateway:r101962
Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects_2_3step.js
@@ -249,8 +249,11 @@
250250 $( "#change-amount" ).show();
251251 }
252252 function validateAmount() {
 253+
 254+ // TODO: THIS NEEDS TO BE REPLACED WITH KALDARI'S CURRENCIES
253255 var minimums = {
254 - 'USD' : 1
 256+ 'USD' : 1,
 257+ 'CAD' : 1
255258 };
256259 var error = true;
257260 var amount = $( 'input[name="amount"]' ).val(); // get the amount
@@ -264,8 +267,7 @@
265268 error = ( amount == null || isNaN( amount ) || amount.value <= 0 );
266269
267270 // Check amount is at least the minimum
268 - var currency_code = 'USD'; // hard-coded for these forms and tests
269 - $( 'input[name="currency_code"]' ).val( currency_code );
 271+ var currency_code = $( 'input[name="currency_code"]' ).val();
270272 if ( typeof( minimums[currency_code] ) == 'undefined' ) {
271273 minimums[currency_code] = 1;
272274 }
Property changes on: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface
___________________________________________________________________
Modified: svn:mergeinfo
273275 Merged /trunk/extensions/DonationInterface:r101962

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101962Adding CAD to js validationpgehres06:07, 4 November 2011

Status & tagging log