r101981 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101980‎ | r101981 | r101982 >
Date:12:01, 4 November 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Followup r101980 - replacing fatal by warning wasn't the ultimate goal
Modified paths:
  • /trunk/extensions/Translate/utils/TranslationHelpers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/TranslationHelpers.php
——@@ -907,7 +907,7 @@
908908
909909 // Using newFromId instead of newFromTitle, because the page might have been renamed
910910 $oldrev = Revision::newFromId( $translationRevision );
911 - if ( !$oldev ) {
 911+ if ( !$oldrev ) {
912912 // And someone might still have deleted it
913913 return null;
914914 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101980Try to fix fatal errornikerabbit11:58, 4 November 2011

Status & tagging log