r101963 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101962‎ | r101963 | r101964 >
Date:06:55, 4 November 2011
Author:jpostlethwaite
Status:resolved
Tags:fundraising 
Comment:
Moved $data call so it is accessible to other parts of code.
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php
@@ -84,6 +84,10 @@
8585 // dispatch forms/handling
8686 if ( $this->adapter->checkTokens() ) {
8787
 88+ //TODO: Get rid of $data out here completely, by putting this logic inside the adapter somewhere.
 89+ //All we seem to be doing with it now, is internal adapter logic outside of the adapter.
 90+ $data = $this->adapter->getDisplayData();
 91+
8892 if ( $this->adapter->posted ) {
8993
9094 // The form was submitted and the payment method has been set
@@ -93,10 +97,6 @@
9498 * An invalid $payment_method will cause an error.
9599 */
96100
97 - //TODO: Get rid of $data out here completely, by putting this logic inside the adapter somewhere.
98 - //All we seem to be doing with it now, is internal adapter logic outside of the adapter.
99 - $data = $this->adapter->getDisplayData();
100 -
101101 $payment_method = ( isset( $data['payment_method'] ) && !empty( $data['payment_method'] ) ) ? $data['payment_method'] : 'cc';
102102 $payment_submethod = ( isset( $data['payment_submethod'] ) && !empty( $data['payment_submethod'] ) ) ? $data['payment_submethod'] : '';
103103

Status & tagging log