r101961 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101960‎ | r101961 | r101962 >
Date:05:47, 4 November 2011
Author:jpostlethwaite
Status:deferred
Tags:fundraising 
Comment:
Updated unit tests to run on test payments.
Modified paths:
  • /trunk/extensions/DonationInterface/tests/macros/form.globalcollect.webitects_2_3step.htm (modified) (history)
  • /trunk/extensions/DonationInterface/tests/macros/form.twostepamount.banktransfer.netherlands.fail.not.a.valid.combination.htm (modified) (history)
  • /trunk/extensions/DonationInterface/tests/macros/form.twostepamount.directdebit.austria.htm (modified) (history)
  • /trunk/extensions/DonationInterface/tests/macros/form.twostepamount.directdebit.belgium.htm (modified) (history)
  • /trunk/extensions/DonationInterface/tests/macros/form.twostepamount.directdebit.italy.htm (modified) (history)
  • /trunk/extensions/DonationInterface/tests/macros/form.twostepamount.directdebit.netherlands.fail.invalid.accountnumber.length.htm (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/tests/macros/form.twostepamount.directdebit.italy.htm
@@ -12,21 +12,6 @@
1313 <tr><td rowspan="1" colspan="3">form.twostepamount.realtimebanktransfer.enets</td></tr>
1414 </thead><tbody>
1515 <tr>
16 - <td>clickAndWait</td>
17 - <td>css=input.button-plain</td>
18 - <td></td>
19 -</tr>
20 -<tr>
21 - <td>verifyTextPresent</td>
22 - <td>Thank you for your support.</td>
23 - <td></td>
24 -</tr>
25 -<tr>
26 - <td>assertTitle</td>
27 - <td>Thank You/en - Wikimedia Foundation</td>
28 - <td></td>
29 -</tr>
30 -<tr>
3116 <td>open</td>
3217 <td>/index.php/Special:GlobalCollectGateway?form_name=TwoStepAmount&amp;payment_method=dd&amp;payment_submethod=dd_it&amp;country=IT</td>
3318 <td></td>
@@ -69,7 +54,7 @@
7055 <tr>
7156 <td>select</td>
7257 <td>id=input_currency_code</td>
73 - <td>label=EUR: Euro</td>
 58+ <td>label=Euro</td>
7459 </tr>
7560 <tr>
7661 <td>type</td>
@@ -111,6 +96,21 @@
11297 <td>id=bank_check_digit</td>
11398 <td>1</td>
11499 </tr>
 100+<tr>
 101+ <td>clickAndWait</td>
 102+ <td>css=input.button-plain</td>
 103+ <td></td>
 104+</tr>
 105+<tr>
 106+ <td>verifyTextPresent</td>
 107+ <td>Thank you for your support.</td>
 108+ <td></td>
 109+</tr>
 110+<tr>
 111+ <td>assertTitle</td>
 112+ <td>Thank You/en - Wikimedia Foundation</td>
 113+ <td></td>
 114+</tr>
115115 </tbody></table>
116116 </body>
117117 </html>
Index: trunk/extensions/DonationInterface/tests/macros/form.globalcollect.webitects_2_3step.htm
@@ -13,7 +13,7 @@
1414 </thead><tbody>
1515 <tr>
1616 <td>open</td>
17 - <td>/index.php/Special:GlobalCollectGateway?form_name=RapidHtml&amp;ffname=webitects_2_3step</td>
 17+ <td>/index.php/Special:GlobalCollectGateway?form_name=RapidHtml&amp;ffname=webitects_2_3step&amp;country=US</td>
1818 <td></td>
1919 </tr>
2020 <tr>
@@ -73,36 +73,6 @@
7474 </tr>
7575 <tr>
7676 <td>click</td>
77 - <td>id=paymentContinueBtn</td>
78 - <td></td>
79 -</tr>
80 -<tr>
81 - <td>click</td>
82 - <td>id=cc-visa</td>
83 - <td></td>
84 -</tr>
85 -<tr>
86 - <td>click</td>
87 - <td>css=img[alt=&quot;Visa&quot;]</td>
88 - <td></td>
89 -</tr>
90 -<tr>
91 - <td>click</td>
92 - <td>id=paymentContinueBtn</td>
93 - <td></td>
94 -</tr>
95 -<tr>
96 - <td>click</td>
97 - <td>id=paymentContinueBtn</td>
98 - <td></td>
99 -</tr>
100 -<tr>
101 - <td>click</td>
102 - <td>id=paymentContinueBtn</td>
103 - <td></td>
104 -</tr>
105 -<tr>
106 - <td>click</td>
10777 <td>id=expertContentHeading</td>
10878 <td></td>
10979 </tr>
Index: trunk/extensions/DonationInterface/tests/macros/form.twostepamount.directdebit.belgium.htm
@@ -54,7 +54,7 @@
5555 <tr>
5656 <td>select</td>
5757 <td>id=input_currency_code</td>
58 - <td>label=EUR: Euro</td>
 58+ <td>label=Euro</td>
5959 </tr>
6060 <tr>
6161 <td>type</td>
Index: trunk/extensions/DonationInterface/tests/macros/form.twostepamount.directdebit.netherlands.fail.invalid.accountnumber.length.htm
@@ -64,7 +64,7 @@
6565 <tr>
6666 <td>type</td>
6767 <td>id=account_number</td>
68 - <td>123456789</td>
 68+ <td>12345678</td>
6969 </tr>
7070 <tr>
7171 <td>type</td>
@@ -92,15 +92,10 @@
9393 <td></td>
9494 </tr>
9595 <tr>
96 - <td>assertTitle</td>
97 - <td>Thank You/en - Wikimedia Foundation</td>
98 - <td></td>
 96+ <td>verifyText</td>
 97+ <td>css=p.payment_error_message.payment_error_message_general</td>
 98+ <td>There was an error processing your transaction. Please try again later.</td>
9999 </tr>
100 -<tr>
101 - <td>verifyTextPresent</td>
102 - <td>Thank you for your support.</td>
103 - <td></td>
104 -</tr>
105100 </tbody></table>
106101 </body>
107102 </html>
Index: trunk/extensions/DonationInterface/tests/macros/form.twostepamount.banktransfer.netherlands.fail.not.a.valid.combination.htm
@@ -59,7 +59,7 @@
6060 <tr>
6161 <td>select</td>
6262 <td>id=input_currency_code</td>
63 - <td>label=USD: U.S. dollar</td>
 63+ <td>label=U.S. dollar</td>
6464 </tr>
6565 <tr>
6666 <td>clickAndWait</td>
Index: trunk/extensions/DonationInterface/tests/macros/form.twostepamount.directdebit.austria.htm
@@ -54,7 +54,7 @@
5555 <tr>
5656 <td>select</td>
5757 <td>id=input_currency_code</td>
58 - <td>label=EUR: Euro</td>
 58+ <td>label=Euro</td>
5959 </tr>
6060 <tr>
6161 <td>type</td>

Status & tagging log