r101821 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101820‎ | r101821 | r101822 >
Date:15:14, 3 November 2011
Author:nikerabbit
Status:deferred
Tags:
Comment:
Stylize
Modified paths:
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaInput.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaWithAutocompleteInput.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_TextWithAutocompleteInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaWithAutocompleteInput.php
@@ -29,11 +29,11 @@
3030 }
3131
3232 public static function getHTML( $cur_value, $input_name, $is_mandatory, $is_disabled, $other_args ) {
33 -
 33+
3434 // TODO: Lots of duplication of code in the parent class. Needs refactoring!
35 -
 35+
3636 global $wgOut;
37 -
 37+
3838 // If 'no autocomplete' was specified, print a regular
3939 // textarea instead.
4040 if ( array_key_exists( 'no autocomplete', $other_args ) &&
@@ -49,10 +49,10 @@
5050 $input_id = 'input_' . $sfgFieldNum;
5151
5252 if ( array_key_exists( 'wikieditor', $other_args ) &&
53 -
 53+
5454 method_exists( $wgOut, 'getResourceLoader' ) &&
5555 in_array( 'jquery.wikiEditor', $wgOut->getResourceLoader()->getModuleNames() ) &&
56 -
 56+
5757 class_exists( 'WikiEditorHooks' ) &&
5858 WikiEditorHooks::isEnabled( 'toolbar' ) ) {
5959
Index: trunk/extensions/SemanticForms/includes/forminputs/SF_TextWithAutocompleteInput.php
@@ -233,7 +233,7 @@
234234 public function getHtmlText() {
235235 return self::getHTML(
236236 $this->mCurrentValue,
237 - $this->mInputName,
 237+ $this->mInputName,
238238 $this->mIsMandatory,
239239 $this->mIsDisabled,
240240 $this->mOtherArgs
Index: trunk/extensions/SemanticForms/includes/forminputs/SF_TextAreaInput.php
@@ -19,15 +19,15 @@
2020 }
2121
2222 public static function getDefaultPropTypes() {
23 - return array('_txt' => array(), '_cod' => array());
 23+ return array( '_txt' => array(), '_cod' => array() );
2424 }
2525
2626 public static function getOtherPropTypesHandled() {
27 - return array('_wpg', '_str');
 27+ return array( '_wpg', '_str' );
2828 }
2929
3030 public static function getOtherPropTypeListsHandled() {
31 - return array('_wpg', '_str');
 31+ return array( '_wpg', '_str' );
3232 }
3333
3434 public static function getHTML( $cur_value, $input_name, $is_mandatory, $is_disabled, $other_args ) {
@@ -39,10 +39,10 @@
4040 $input_id = $input_name == 'free_text' ? 'free_text' : "input_$sfgFieldNum";
4141
4242 if ( array_key_exists( 'wikieditor', $other_args ) &&
43 -
 43+
4444 method_exists( $wgOut, 'getResourceLoader' ) &&
4545 in_array( 'jquery.wikiEditor', $wgOut->getResourceLoader()->getModuleNames() ) &&
46 -
 46+
4747 class_exists( 'WikiEditorHooks' ) &&
4848 WikiEditorHooks::isEnabled( 'toolbar' ) ) {
4949
@@ -126,7 +126,7 @@
127127 if ( $is_mandatory ) {
128128 $spanClass .= ' mandatoryFieldSpan';
129129 }
130 - $text = Xml::tags( 'span', array('class' => $spanClass), $text );
 130+ $text = Xml::tags( 'span', array( 'class' => $spanClass ), $text );
131131
132132 return $text;
133133 }