r101817 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101816‎ | r101817 | r101818 >
Date:15:06, 3 November 2011
Author:hashar
Status:ok
Tags:
Comment:
comment that isValidURI must reject file:// URI
Modified paths:
  • /trunk/phase3/includes/HttpFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HttpFunctions.php
@@ -129,6 +129,8 @@
130130 * protocols, because we only want protocols that both cURL
131131 * and php support.
132132 *
 133+ * file:// should not be allowed there for security purpose (r67684)
 134+ *
133135 * @fixme this is wildly inaccurate and fails to actually check most stuff
134136 *
135137 * @param $uri Mixed: URI to check for validity

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101808use isValidURI for redirect checkmah14:04, 3 November 2011

Status & tagging log