r101753 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101752‎ | r101753 | r101754 >
Date:23:59, 2 November 2011
Author:awjrichards
Status:deferred
Tags:
Comment:
Updating DonationData to properly handled utm_source_id - change got mangled in MFT
Modified paths:
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/DonationData.php (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_common/DonationData.php
@@ -66,7 +66,7 @@
6767 'numAttempt' => $wgRequest->getVal( 'numAttempt', '0' ),
6868 'referrer' => ( $wgRequest->getVal( 'referrer' ) ) ? $wgRequest->getVal( 'referrer' ) : $wgRequest->getHeader( 'referer' ),
6969 'utm_source' => $wgRequest->getText( 'utm_source' ),
70 - 'utm_source_id' => $wgRequest->getVal( 'utm_source_id', 0 ),
 70+ 'utm_source_id' => $wgRequest->getVal( 'utm_source_id', null ),
7171 'utm_medium' => $wgRequest->getText( 'utm_medium' ),
7272 'utm_campaign' => $wgRequest->getText( 'utm_campaign' ),
7373 // try to honor the user-set language (uselang), otherwise the language set in the URL (language)
@@ -199,7 +199,7 @@
200200 'numAttempt' => 0,
201201 'referrer' => 'http://www.baz.test.com/index.php?action=foo&action=bar',
202202 'utm_source' => 'test_src',
203 - 'utm_source_id' => 0,
 203+ 'utm_source_id' => null,
204204 'utm_medium' => 'test_medium',
205205 'utm_campaign' => 'test_campaign',
206206 'language' => 'en',

Status & tagging log