r101719 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101718‎ | r101719 | r101720 >
Date:22:08, 2 November 2011
Author:kaldari
Status:ok
Tags:
Comment:
follow-up to 101700, better security
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/RapidHtml.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/RapidHtml.php
@@ -91,7 +91,8 @@
9292 // Get error passed via query string
9393 $error = $wgRequest->getText( 'error' );
9494 if ( $error ) {
95 - $form_errors['general'][] = $error;
 95+ // We escape HTML here since only quotes are escaped later
 96+ $form_errors['general'][] = htmlspecialchars( $error );
9697 }
9798
9899 if ( $country != '' ){

Follow-up revisions

RevisionCommit summaryAuthorDate
r101746MFT r101074, r101217, r101236, r101382, r101501, r101503, r101504, r101512, r...awjrichards23:23, 2 November 2011

Status & tagging log