r10167 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r10166‎ | r10167 | r10168 >
Date:22:12, 16 July 2005
Author:kateturner
Status:old
Tags:
Comment:
don't ignore the first file on the command line
fix typo in schema
Modified paths:
  • /trunk/logwood/fe/logwood.php (modified) (history)
  • /trunk/logwood/logwood.c (modified) (history)
  • /trunk/logwood/statstables.sql (modified) (history)

Diff [purge]

Index: trunk/logwood/statstables.sql
@@ -114,7 +114,7 @@
115115 ta_agent INTEGER NOT NULL REFERENCES agent_ids(ag_id) ON DELETE CASCADE,
116116 ta_count INTEGER NOT NULL
117117 );
118 -CREATE INDEX ta_count_idx ON toprefs(ta_site, ta_count);
 118+CREATE INDEX ta_count_idx ON topagents(ta_site, ta_count);
119119
120120 DROP TABLE IF EXISTS wdays;
121121 CREATE TABLE wdays (
Index: trunk/logwood/fe/logwood.php
@@ -58,7 +58,7 @@
5959 </style>
6060 </head>
6161 <body>
62 -<form action='logwood.php' method='get'>
 62+<form action='' method='get'>
6363
6464 <?php
6565 $site = false;
Index: trunk/logwood/logwood.c
@@ -65,8 +65,8 @@
6666 #define STMT_INCR_AGENT "UPDATE agent_count SET ac_count = ac_count + 1, ac_touched = NOW() WHERE ac_id = ?"
6767
6868 #define STMT_QUERY_WDAY "SELECT COUNT(*) FROM wdays WHERE wd_site = ? AND wd_day = ?"
69 -#define STMT_INSERT_WDAY "INSERT INTO wdays (wd_site, wg_day, wd_hits) VALUES (?, ?, 0)"
70 -#define STMT_UPDATE_WDAY "UPDATE wdays SET wd_hits = wd_hits + 1 WHERE wd_site = ? AND wd_day = ?"
 69+#define STMT_INSERT_WDAY "INSERT INTO wdays (wd_site, wd_day, wd_hits) VALUES (?, ?, 0)"
 70+#define STMT_UPDATE_WDAY "UPDATE wdays SET wd_hits = wd_hits + 1 WHERE wd_site = ? AND wd_day = ?"
7171
7272 int
7373 main(argc, argv)
@@ -137,7 +137,7 @@
138138 exit(1);
139139 }
140140
141 - for (argv++; *argv; argv++) {
 141+ for (; *argv; argv++) {
142142 process_file(*argv);
143143 }
144144

Status & tagging log