r101547 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101546‎ | r101547 | r101548 >
Date:22:40, 1 November 2011
Author:kaldari
Status:ok
Tags:
Comment:
some tweaks for webitects globalcollect form
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/webitects_2_3step.html (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects_2_3step.js (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/webitects_2_3step.html
@@ -127,7 +127,7 @@
128128 </div>
129129 <div id="step3header"><h3>%donate_interface-cc-form-header-payment% <span class="mute" id="change-payment" style="display: none;">(<a href="#">%donate_interface-change%</a>)</span></h3></div>
130130 <div id="step3wrapper" style="display: none;">
131 - <div id="payment" class="gainlayout" style="height:300px;text-align:center;"></div>
 131+ <div id="payment" class="gainlayout" style="height:314px;text-align:center;"></div>
132132 </div>
133133
134134 <input type="hidden" name="returnto" value="Thank_You/en" />
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects_2_3step.js
@@ -60,6 +60,11 @@
6161 $( ".hint" ).ezpz_hint();
6262
6363 $( "#cc" ).click( function() {
 64+ /* safety check for people who hit the back button */
 65+ checkedValue = $( "input[name='amountRadio']:checked" ).val();
 66+ if ( $( 'input[name="amount"]' ).val() == '0.00' && checkedValue && !isNaN( checkedValue ) ) {
 67+ setAmount( checkedValue );
 68+ }
6469 if ( validateAmount() ) {
6570 showAmount( $( 'input[name="amount"]' ) );
6671 showStep2();
@@ -67,6 +72,11 @@
6873 } );
6974
7075 $( "#pp" ).click( function() {
 76+ /* safety check for people who hit the back button */
 77+ checkedValue = $( "input[name='amountRadio']:checked" ).val();
 78+ if ( $( 'input[name="amount"]' ).val() == '0.00' && checkedValue && !isNaN( checkedValue ) ) {
 79+ setAmount( checkedValue );
 80+ }
7181 if ( validateAmount() ) {
7282 // set the action to go to PayPal
7383 $( 'input[name="gateway"]' ).val( "paypal" );
@@ -185,7 +195,7 @@
186196 $( '#payment' ).empty();
187197 // Insert the iframe into the form
188198 $( '#payment' ).append(
189 - '<iframe src="'+data.result.formaction+'" width="318" height="300" frameborder="0"></iframe>'
 199+ '<iframe src="'+data.result.formaction+'" width="318" height="314" frameborder="0"></iframe>'
190200 );
191201
192202 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r101746MFT r101074, r101217, r101236, r101382, r101501, r101503, r101504, r101512, r...awjrichards23:23, 2 November 2011

Status & tagging log