r101534 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101533‎ | r101534 | r101535 >
Date:21:39, 1 November 2011
Author:kaldari
Status:ok
Tags:
Comment:
legal terms update, part 1. follow-up coming soon
Modified paths:
  • /trunk/extensions/WikiLove/WikiLove.i18n.php (modified) (history)
  • /trunk/extensions/WikiLove/WikiLove.php (modified) (history)
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/WikiLove.php
@@ -143,6 +143,8 @@
144144 'wikilove-commons-url',
145145 'wikilove-err-preview-api',
146146 'wikilove-err-send-api',
 147+ 'wikilove-terms',
 148+ 'wikilove-terms-link',
147149 ),
148150 'dependencies' => array(
149151 'ext.wikiLove.defaultOptions',
Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.css
@@ -238,7 +238,7 @@
239239 /*#mw-wikilove-dialog*/ #mw-wikilove-add-details .mw-wikilove-note {
240240 font-weight: light;
241241 font-size: 0.9em;
242 - color: #999;
 242+ color: #888888;
243243 }
244244
245245 /*#mw-wikilove-dialog*/ #mw-wikilove-add-details textarea {
@@ -325,6 +325,13 @@
326326 float: right;
327327 }
328328
 329+#mw-wikilove-dialog #mw-wikilove-terms {
 330+ margin: 0.5em 0;
 331+ text-align: right;
 332+ font-size: 0.9em;
 333+ color: #888888;
 334+}
 335+
329336 #mw-wikilove-dialog .mw-wikilove-spinner {
330337 float: right;
331338 margin-top: 0.9em;
Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -109,6 +109,7 @@
110110 <span class="mw-wikilove-number">3</span>\
111111 <h3><html:msg key="wikilove-preview"/></h3>\
112112 <div id="mw-wikilove-preview-area"></div>\
 113+ <div id="mw-wikilove-terms"></div>\
113114 <form id="mw-wikilove-send-form">\
114115 <button class="submit" id="mw-wikilove-button-send" type="submit"></button>\
115116 <div id="mw-wikilove-send-spinner" class="mw-wikilove-spinner"></div>\
Index: trunk/extensions/WikiLove/WikiLove.i18n.php
@@ -56,6 +56,8 @@
5757 'wikilove-commons-text' => 'You can find images by browsing $1.',
5858 'wikilove-commons-link' => 'Wikimedia Commons',
5959 'wikilove-commons-url' => 'http://commons.wikimedia.org',
 60+ 'wikilove-terms' => 'By submitting, you agree to transparency under these $1.',
 61+ 'wikilove-terms-link' => 'terms',
6062 );
6163
6264 /** Message documentation (Message documentation)
@@ -79,7 +81,7 @@
8082 'wikilove-add-details' => '[[File:Wiki Love 003.png|thumb]]',
8183 'wikilove-image' => '[[File:Wiki Love 004.png|thumb]]',
8284 'wikilove-header' => '[[File:Wiki Love 003.png|thumb]]
83 -Header is the subject of the added message (so perhaps subject is a better term..), i.e. what gets between == ... ==',
 85+Header is the subject of the added message (so perhaps subject is a better term..), i.e. what gets added between == ... ==',
8486 'wikilove-title' => '[[File:Wiki Love 004.png|thumb]]
8587 Title is the title of the wikilove box (e.g. "Barnstar")',
8688 'wikilove-enter-message' => '[[File:Wiki Love 003.png|thumb]]',
@@ -111,6 +113,9 @@
112114 'wikilove-commons-text' => '[[File:Wiki Love 004.png|thumb]]
113115 $1 gets replaced by a link with {{msg-mw|wikilove-commons-link}} ("Wikimedia Commons") as caption and {{msg-mw|wikilove-commons-url}} as URL.',
114116 'wikilove-commons-url' => 'This URL can be changed to point at a localised page on Wikimedia Commons.',
 117+ 'wikilove-terms' => '[[File:Wiki_Love_003.png]]
 118+A notice that appears above the Send WikiLove button in small text. Try to keep this concise. $1 is replaced with the actual link.',
 119+ 'wikilove-terms-link' => 'The text that links to the terms of service. Should not be capitalized.',
115120 );
116121
117122 /** Afrikaans (Afrikaans)

Follow-up revisions

RevisionCommit summaryAuthorDate
r1016601.18wmf1: Merge stuff for editor engagement deployment...catrope19:01, 2 November 2011

Status & tagging log