r101427 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101426‎ | r101427 | r101428 >
Date:23:05, 31 October 2011
Author:inez
Status:deferred
Tags:
Comment:
getLineIndex -> getRenderedLineIndex
Modified paths:
  • /trunk/parsers/wikidom/lib/hype/views/es.ContentView.js (modified) (history)

Diff [purge]

Index: trunk/parsers/wikidom/lib/hype/views/es.ContentView.js
@@ -200,8 +200,8 @@
201201 es.ContentView.prototype.drawSelection = function( range ) {
202202 range.normalize();
203203
204 - var fromLineIndex = this.getLineIndex( range.start ),
205 - toLineIndex = this.getLineIndex( range.end ),
 204+ var fromLineIndex = this.getRenderedLineIndex( range.start ),
 205+ toLineIndex = this.getRenderedLineIndex( range.end ),
206206 fromPosition = this.getRenderedPositionFromOffset( range.start ),
207207 toPosition = this.getRenderedPositionFromOffset( range.end );
208208
@@ -261,7 +261,7 @@
262262 * @param {Integer} offset Offset to get line for
263263 * @returns {Integer} Index of rendered lin offset is within
264264 */
265 -es.ContentView.prototype.getLineIndex = function( offset ) {
 265+es.ContentView.prototype.getRenderedLineIndex = function( offset ) {
266266 for ( var i = 0; i < this.lines.length; i++ ) {
267267 if ( this.lines[i].range.containsOffset( offset ) ) {
268268 return i;

Status & tagging log