r101394 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101393‎ | r101394 | r101395 >
Date:19:50, 31 October 2011
Author:aaron
Status:ok
Tags:
Comment:
* Made mRedirectTarget, mLastRevision, mTimestamp, mTouched of WikiPage protected; no outside users.
* Added TODO comment to doRollback() and fixed mLatest comment.
Modified paths:
  • /trunk/phase3/includes/WikiPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WikiPage.php
@@ -24,21 +24,21 @@
2525 public $mCounter = -1; // !< Integer (-1 means "not loaded")
2626 public $mDataLoaded = false; // !< Boolean
2727 public $mIsRedirect = false; // !< Boolean
28 - public $mLatest = false; // !< Boolean
 28+ public $mLatest = false; // !< Integer (false means "not loaded")
2929 public $mPreparedEdit = false; // !< Array
3030
3131 /**
3232 * @var Title
3333 */
34 - public $mRedirectTarget = null;
 34+ protected $mRedirectTarget = null;
3535
3636 /**
3737 * @var Revision
3838 */
39 - public $mLastRevision = null;
 39+ protected $mLastRevision = null;
4040
41 - public $mTimestamp = ''; // !< String
42 - public $mTouched = '19700101000000'; // !< String
 41+ protected $mTimestamp = ''; // !< String
 42+ protected $mTouched = '19700101000000'; // !< String
4343 /**@}}*/
4444
4545 /**
@@ -1758,6 +1758,8 @@
17591759 * roll back to, e.g. user is the sole contributor. This function
17601760 * performs permissions checks on $user, then calls commitRollback()
17611761 * to do the dirty work
 1762+ *
 1763+ * @todo: seperate the business/permission stuff out from backend code
17621764 *
17631765 * @param $fromP String: Name of the user whose edits to rollback.
17641766 * @param $summary String: Custom summary. Set to default summary if empty.

Status & tagging log