r101363 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101362‎ | r101363 | r101364 >
Date:16:33, 31 October 2011
Author:ialex
Status:ok
Tags:
Comment:
* (bug 31818) 'usercreated' message now supports GENDER
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialListusers.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -122,6 +122,7 @@
123123 * (bug 29912) Unit tests break if parsertest tables are still present
124124 * (bug 19186) Special:UserLogin's title on Special:SpecialPages now says
125125 "create account" when the user cannot create an account
 126+* (bug 31818) 'usercreated' message now supports GENDER
126127
127128 === API changes in 1.19 ===
128129 * (bug 19838) siprop=interwikimap can now use the interwiki cache.
Index: trunk/phase3/includes/specials/SpecialListusers.php
@@ -161,8 +161,7 @@
162162 if( $row->creation ) {
163163 $d = $lang->date( wfTimestamp( TS_MW, $row->creation ), true );
164164 $t = $lang->time( wfTimestamp( TS_MW, $row->creation ), true );
165 - $created = ' (' . wfMsg( 'usercreated', $d, $t ) . ')';
166 - $created = htmlspecialchars( $created );
 165+ $created = ' (' . wfMsgExt( 'usercreated', array( 'parsemag', 'escape' ), $d, $t, $row->user_name ) . ')';
167166 }
168167
169168 wfRunHooks( 'SpecialListusersFormatRow', array( &$item, $row ) );
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2540,7 +2540,7 @@
25412541 'listusers-editsonly' => 'Show only users with edits',
25422542 'listusers-creationsort' => 'Sort by creation date',
25432543 'usereditcount' => '$1 {{PLURAL:$1|edit|edits}}',
2544 -'usercreated' => 'Created on $1 at $2',
 2544+'usercreated' => '{{GENDER:$3|Created}} on $1 at $2',
25452545 'newpages' => 'New pages',
25462546 'newpages-summary' => '', # do not translate or duplicate this message to other languages
25472547 'newpages-username' => 'Username:',

Status & tagging log