r101359 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101358‎ | r101359 | r101360 >
Date:14:51, 31 October 2011
Author:hashar
Status:ok
Tags:
Comment:
guessVariant doc and explicit boolean typecast
Modified paths:
  • /branches/nikola/phase3/languages/classes/LanguageSr.php (modified) (history)

Diff [purge]

Index: branches/nikola/phase3/languages/classes/LanguageSr.php
@@ -151,7 +151,12 @@
152152
153153 /**
154154 * Guess if a text is written in Cyrillic or Latin.
 155+ * Overrides LanguageConverter::guessVariant()
155156 *
 157+ * @param string $text The text to be checked
 158+ * @param string $variant Language code of the variant to be checked for
 159+ * @return bool true if $text appears to be written in $variant
 160+ *
156161 * @author Nikola Smolenski <smolensk@eunet.rs>
157162 * @since 1.18
158163 */
@@ -160,9 +165,9 @@
161166 $numLatin = preg_match_all("/[šđč枊ĐČĆŽ]/u", $text, $dummy);
162167
163168 if( $variant == 'sr-ec' ) {
164 - return $numCyrillic > $numLatin;
 169+ return (boolean) ($numCyrillic > $numLatin);
165170 } else if( $variant == 'sr-el' ) {
166 - return $numLatin > $numCyrillic;
 171+ return (boolean) ($numLatin > $numCyrillic);
167172 } else {
168173 return false;
169174 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r103327bug 28643 improvement to serbian variants conversion...hashar15:12, 16 November 2011

Status & tagging log