r101353 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101352‎ | r101353 | r101354 >
Date:11:56, 31 October 2011
Author:hashar
Status:reverted
Tags:
Comment:
remove exception added by r101346

That would break every sites not having $wgEnableJavaScriptTest set
since r101352 call that method unconditionally.
Modified paths:
  • /branches/JSTesting/includes/resourceloader/ResourceLoader.php (modified) (history)

Diff [purge]

Index: branches/JSTesting/includes/resourceloader/ResourceLoader.php
——@@ -278,7 +278,7 @@
279279 public function registerTestModules() {
280280 global $wgEnableJavaScriptTest, $IP;
281281 if ( $wgEnableJavaScriptTest === false ) {
282 - throw new MWException( 'Attempt to register JavaScript test modules but <tt>$wgEnableJavaScriptTest</tt> is false. Edit your <tt>LocalSettings.php</tt> to enable it.' );
 282+ return false;
283283 }
284284
285285 wfProfileIn( __METHOD__ );

Follow-up revisions

RevisionCommit summaryAuthorDate
r101383[JSTesting] Restore loading principle....krinkle18:56, 31 October 2011
r101384[JSTesting] Match the other wgEnableJavaScriptTest checks (just in case)....krinkle18:57, 31 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101346now explicitly need to register test modules....hashar10:15, 31 October 2011
r101352unconditionally register the test modules...hashar11:51, 31 October 2011

Status & tagging log