r101339 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101338‎ | r101339 | r101340 >
Date:08:38, 31 October 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r96944: rename "Replace next" button to "Replace" cause that's what it does now
Modified paths:
  • /trunk/extensions/WikiEditor/WikiEditor.i18n.php (modified) (history)
  • /trunk/extensions/WikiEditor/WikiEditor.php (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.dialogs.config.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/WikiEditor.php
@@ -295,7 +295,7 @@
296296 'wikieditor-toolbar-tool-replace-case',
297297 'wikieditor-toolbar-tool-replace-regex',
298298 'wikieditor-toolbar-tool-replace-button-findnext',
299 - 'wikieditor-toolbar-tool-replace-button-replacenext',
 299+ 'wikieditor-toolbar-tool-replace-button-replace',
300300 'wikieditor-toolbar-tool-replace-button-replaceall',
301301 'wikieditor-toolbar-tool-replace-close',
302302 'wikieditor-toolbar-tool-replace-nomatch',
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.dialogs.config.js
@@ -1132,7 +1132,7 @@
11331133 $(this).closest( '.ui-dialog' ).data( 'dialogaction', e.target );
11341134 $(this).data( 'replaceCallback' ).call( this, 'find' );
11351135 },
1136 - 'wikieditor-toolbar-tool-replace-button-replacenext': function( e ) {
 1136+ 'wikieditor-toolbar-tool-replace-button-replace': function( e ) {
11371137 $(this).closest( '.ui-dialog' ).data( 'dialogaction', e.target );
11381138 $(this).data( 'replaceCallback' ).call( this, 'replace' );
11391139 },
Index: trunk/extensions/WikiEditor/WikiEditor.i18n.php
@@ -164,7 +164,7 @@
165165 'wikieditor-toolbar-tool-replace-case' => 'Match case',
166166 'wikieditor-toolbar-tool-replace-regex' => 'Treat search string as a regular expression',
167167 'wikieditor-toolbar-tool-replace-button-findnext' => 'Find next',
168 - 'wikieditor-toolbar-tool-replace-button-replacenext' => 'Replace next',
 168+ 'wikieditor-toolbar-tool-replace-button-replace' => 'Replace',
169169 'wikieditor-toolbar-tool-replace-button-replaceall' => 'Replace all',
170170 'wikieditor-toolbar-tool-replace-close' => 'Close',
171171 'wikieditor-toolbar-tool-replace-nomatch' => 'Your search did not match anything.',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96944(bug 20919) Search & Replace: Change "Replace Next" functionality to "Replace...siebrand08:53, 13 September 2011

Status & tagging log