r101257 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101256‎ | r101257 | r101258 >
Date:12:26, 29 October 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Looks like my simple Ajax buttons cause two different bugs in two different browsers
* Firefox marks same number of buttons disabled on page refresh what there was before refresh
* Chrome fails to submit ajax requests in https mode about 90% of the time

This commit fixes the bug with Firefox by giving unique name attribute to the buttons
Modified paths:
  • /trunk/extensions/Translate/utils/MessageTable.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/MessageTable.php
——@@ -218,6 +218,7 @@
219219 'class' => 'mw-translate-messagereviewbutton',
220220 'data-token' => ApiTranslationReview::getToken( 0, '' ),
221221 'data-revision' => $revision,
 222+ 'name' => 'acceptbutton-' . $revision, // Otherwise Firefox disables buttons on page load
222223 );
223224
224225 $reviewers = (array) $message->getProperty( 'reviewers' );

Status & tagging log